View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0001445 | OpenMPT | Feature Request | public | 2021-04-15 13:39 | 2021-06-02 22:52 |
Reporter | Polaris911 | Assigned To | Saga Musix | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | resolved | Resolution | fixed | ||
Platform | x64 | OS | Windows | OS Version | 10 |
Product Version | OpenMPT 1.29.07.00 / libopenmpt 0.5.5 (upgrade first) | ||||
Target Version | OpenMPT 1.30.01.00 / libopenmpt 0.6.0 (upgrade first) | Fixed in Version | OpenMPT 1.30.01.00 / libopenmpt 0.6.0 (upgrade first) | ||
Summary | 0001445: Make instrument name auto-populate with the sample's name | ||||
Description | When I click "Insert sample", I get a popup "Do you want to make an instrument too?". The answer is always YES. Then I drag a WAV from the Tree into the sample. The waveform appears, the name and filename fields are filled out in Sample tab. But when I click on the Instrument tab, the name field is blank. It would be helpful if the name auto-populated on the instrument name field so when I am scrolling through instruments trying to find one, I don't have to preview every single sound to see what it is. (It would also be helpful to see the waveform in Instrument tab, but having a name at least would be an improvement). Having to type all the names in by hand takes forever. | ||||
Tags | No tags attached. | ||||
Has the bug occurred in previous versions? | |||||
Tested code revision (in case you know it) | |||||
In general it's a great idea but we have to keep some things in mind: What happens if you load a new sample, or if you manually type a name? It might be pretty useless if you try a few different samples and the instrument sticks to the name of the first sample you loaded. Loading a sample should maybe overwrite the instrument name in some cases but not all: Maybe only when the instrument and sample name are identical? |
|
r14609 implements this in the following way: If a new sample is loaded, or a sample is renamed manually, the first instrument referring to that sample gets its name updated if:
an 1.30 test build will be available soon from https://builds.openmpt.org/builds/ |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2021-04-15 13:39 | Polaris911 | New Issue | |
2021-04-15 13:40 | Polaris911 | Summary | Make instrument name auto-populate the sample's name => Make instrument name auto-populate with the sample's name |
2021-04-15 18:37 | Saga Musix | Note Added: 0004710 | |
2021-04-15 19:21 | Saga Musix | Assigned To | => Saga Musix |
2021-04-15 19:21 | Saga Musix | Status | new => assigned |
2021-04-15 19:28 | Saga Musix | Note Added: 0004711 | |
2021-04-15 19:28 | Saga Musix | Status | assigned => feedback |
2021-04-15 19:28 | Saga Musix | Target Version | => OpenMPT 1.30.01.00 / libopenmpt 0.6.0 (upgrade first) |
2021-06-02 22:52 | Saga Musix | Status | feedback => resolved |
2021-06-02 22:52 | Saga Musix | Resolution | open => fixed |
2021-06-02 22:52 | Saga Musix | Fixed in Version | => OpenMPT 1.30.01.00 / libopenmpt 0.6.0 (upgrade first) |