View Issue Details

IDProjectCategoryView StatusLast Update
0001445OpenMPTFeature Requestpublic2021-06-02 22:52
ReporterPolaris911 Assigned ToSaga Musix  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Platformx64OSWindowsOS Version10
Product VersionOpenMPT 1.29.07.00 / libopenmpt 0.5.5 (upgrade first) 
Target VersionOpenMPT 1.30 / libopenmpt 0.6 (goals)Fixed in VersionOpenMPT 1.30 / libopenmpt 0.6 (goals) 
Summary0001445: Make instrument name auto-populate with the sample's name
Description

When I click "Insert sample", I get a popup "Do you want to make an instrument too?". The answer is always YES. Then I drag a WAV from the Tree into the sample. The waveform appears, the name and filename fields are filled out in Sample tab. But when I click on the Instrument tab, the name field is blank.

It would be helpful if the name auto-populated on the instrument name field so when I am scrolling through instruments trying to find one, I don't have to preview every single sound to see what it is. (It would also be helpful to see the waveform in Instrument tab, but having a name at least would be an improvement). Having to type all the names in by hand takes forever.

TagsNo tags attached.
Has the bug occurred in previous versions?
Tested code revision (in case you know it)

Activities

Saga Musix

Saga Musix

2021-04-15 18:37

administrator   ~0004710

In general it's a great idea but we have to keep some things in mind: What happens if you load a new sample, or if you manually type a name? It might be pretty useless if you try a few different samples and the instrument sticks to the name of the first sample you loaded. Loading a sample should maybe overwrite the instrument name in some cases but not all: Maybe only when the instrument and sample name are identical?

Saga Musix

Saga Musix

2021-04-15 19:28

administrator   ~0004711

r14609 implements this in the following way:

If a new sample is loaded, or a sample is renamed manually, the first instrument referring to that sample gets its name updated if:

  • The instrument previously had the same name as the sample or it had no name
  • The instrument references no other samples

an 1.30 test build will be available soon from https://builds.openmpt.org/builds/

Issue History

Date Modified Username Field Change
2021-04-15 13:39 Polaris911 New Issue
2021-04-15 13:40 Polaris911 Summary Make instrument name auto-populate the sample's name => Make instrument name auto-populate with the sample's name
2021-04-15 18:37 Saga Musix Note Added: 0004710
2021-04-15 19:21 Saga Musix Assigned To => Saga Musix
2021-04-15 19:21 Saga Musix Status new => assigned
2021-04-15 19:28 Saga Musix Note Added: 0004711
2021-04-15 19:28 Saga Musix Status assigned => feedback
2021-04-15 19:28 Saga Musix Target Version => OpenMPT 1.30 / libopenmpt 0.6 (goals)
2021-06-02 22:52 Saga Musix Status feedback => resolved
2021-06-02 22:52 Saga Musix Resolution open => fixed
2021-06-02 22:52 Saga Musix Fixed in Version => OpenMPT 1.30 / libopenmpt 0.6 (goals)