Related Wine bug report: https://bugs.winehq.org/show_bug.cgi?id=49802

The only usages of _beginthreadex should be in PortAudio and RtAudio. PortAudio already can use CreateThread as an alternative for WinCE, so I'm not sure why they don't use it for plain Win32. Maybe we should enforce its usage on Win32 as well. RtAudio hardcodes its _beginthreadex usage. Maybe we can enforce that component to be disabled on macOS for now. The relevant code is not compiled into OpenMPT, so RtAudio should not be a problem.

I'll verify later that these solutions work on macOS.

Edit: It doesn't, the crash still occurs. Probably caused by one of our std::threads then.

Do we know if building with VS2017 works for Wine on macOS?

OpenMPT 1.28 works with Wine on macOS. Compiling the latest 1.30 code with VS2017 doesn't work. See attached log. It just freezes after that.

Do we know if this is due to a breaking change in later VS2017 updates, or due to our changes? i.e. does 1.28 with current VS2017 work?

Recently-compiled 1.28 still works.

So we could bisect trunk from 1.28 branch point on and find the change that broke Wine on macOS. And if it is fixable with reasonable effort, we could switch 1.30 (and maybe also 1.29) builds to VS2017 as a work-around.

amd64 RETRO builds targeting Windows XP do work in Wine on macOS, and will hopefully continue to do so after r16139, See https://developercommunity.visualstudio.com/t/64-bit-exes-built-with-vs2019-crash-under-wine-on/1248753#T-N1609837. This is far from perfect as these are not included in the intended installer package, but better than the situation before.

r17389

[Fix] build: Use Windows 11 SDK 10.0.22621.0 for VS2022 builds. This SDK is included since VS2022 17.2.3. Apparently, this fixes the segment register access in the UCRT which caused OpenMPT to fail on Wine on macOS. See https://bugs.openmpt.org/view.php?id=1424 and https://developercommunity.visualstudio.com/t/64-bit-EXEs-built-with-VS2019-crash-unde/1248753. As Microsoft in their infinite wisdom and incompetence again fails to provide release notes (https://developercommunity.visualstudio.com/t/no-Release-Notes-for-Windows-11-SDK-100/10061520), we cannot know if this SDK still supports older Windows versions. Thus, for Windows 7 and Windows 8.1, stick with an older Windows 10 SDK version for now. Microsoft is just great.

To consider back-porting to 1.30, we should at least wait until support for older Windows versions has been confirmed for this SDK version.

See https://developercommunity.visualstudio.com/t/64-bit-exes-built-with-vs2019-crash-under-wine-on/1248753#TPIN-N10088359.

We use Windows 10 SDK 10.0.22621.0 for 1.31.