| Description | This specific Adlib-kind S3M file loads one of the samples incorrectly, and so it doesn't play right.
I've been able to locate the problem on the sample speed, which is incorrectly loaded in openMPT as 1024768Hz, while the rest of the samples are "correctly" set to 8363 (aside of one of them that has a different value intentionally).
It was created with Scream Tracker 3 in 1997, and has 0000 as the speed in all samples (except the different one), so I don't know why some are remapped to 8363 as they should, but not the last one.
(See additional info) |
|---|
| Additional Information | I checked the code and located what might be the problem in S3MSampleHeader::ConvertToMPT
https://source.openmpt.org/browse/openmpt/trunk/OpenMPT/soundlib/S3MTools.cpp
What I believe that happens is that probably this file has, due to a bug or something, some of the upper bits in the c5speed set at 1 while it should all be zero, so the if checks in S3MTools do accept the invalid speed.
Probably, it is needed, at least if the file is detected to come from Scream Tracker, that the upper limit is clipped at 0xFFFF (setting it to 8363 just like with the value 0), or something.
like:
// C-5 frequency
mptSmp.nC5Speed = c5speed;
if(mptSmp.nC5Speed == 0 || (isST3 && mptSmp.nC5Speed > 0xFFFF))
{
mptSmp.nC5Speed = 8363;
} else if(mptSmp.nC5Speed < 1024)
{
mptSmp.nC5Speed = 1024;
|
|---|
