0001357: When you delete a pattern, undoing the delete cannot be redone and doesn't reload tree view - OpenMPT Issue Tracker

ID	Project	Category	View Status	Date Submitted	Last Update

0001357	OpenMPT	User Interface	public	2020-08-24 07:23	2020-08-24 23:44

Reporter	nyanpasu64	Assigned To	Saga Musix
Priority	normal	Severity	minor	Reproducibility	sometimes
Status	resolved	Resolution	fixed
Product Version	OpenMPT 1.29.02.00 / libopenmpt 0.5.1 (upgrade first)
Target Version	OpenMPT 1.29.03.00 / libopenmpt 0.5.2 (upgrade first)	Fixed in Version	OpenMPT 1.29.03.00 / libopenmpt 0.5.2 (upgrade first)

Summary	0001357: When you delete a pattern, undoing the delete cannot be redone and doesn't reload tree view
Description	In the tree view, if you delete a pattern, undo will not reload the tree view (the pattern won't reappear), and you can't redo the deletion.
Steps To Reproduce	Create a document in OpenMPT (I used .IT). Either stay in the General tab, or switch to Patterns. In the left tree view, expand "Patterns" (not Sequence), and delete one pattern. You cannot undo this unless the main window is in the Patterns tab. Switch there if you haven't done so. (label A) Undo the operation. The pattern is back, but doesn't appear in the tree view until you right-click and click Refresh. You cannot redo the operation. (In initial testing with an empty pattern, I was sometimes able to make both undo and redo act normally, and IIRC the pattern would disappear and reappear normally in the tree view. But in later testing, the bug always happens.)
Additional Information	Other oddities/bugs observed at label A: If you deleted the pattern the editor was pointing to, the editor shows a a horizontal line, 0 rows tall. If the pattern number was in the order list, it remains black until you cause the order list to redraw (eg. clicking on it).
Tags	No tags attached.

Has the bug occurred in previous versions?
Tested code revision (in case you know it)

Date Modified	Username	Field	Change
2020-08-24 07:23	nyanpasu64	New Issue
2020-08-24 07:24	nyanpasu64	Steps to Reproduce Updated
2020-08-24 12:50	nyanpasu64	Steps to Reproduce Updated
2020-08-24 17:41	Saga Musix	Assigned To	=> Saga Musix
2020-08-24 17:41	Saga Musix	Status	new => assigned
2020-08-24 23:44	Saga Musix	Status	assigned => resolved
2020-08-24 23:44	Saga Musix	Resolution	open => fixed
2020-08-24 23:44	Saga Musix	Product Version	=> OpenMPT 1.29.02.00 / libopenmpt 0.5.1 (upgrade first)
2020-08-24 23:44	Saga Musix	Fixed in Version	=> OpenMPT 1.29.03.00 / libopenmpt 0.5.2 (upgrade first)
2020-08-24 23:44	Saga Musix	Target Version	=> OpenMPT 1.29.03.00 / libopenmpt 0.5.2 (upgrade first)
2020-08-24 23:44	Saga Musix	Note Added: 0004430