View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0001339 | OpenMPT | General | public | 2020-06-11 14:19 | 2020-07-25 21:47 |
Reporter | ASIKWUSpulse | Assigned To | Saga Musix | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | resolved | Resolution | fixed | ||
Product Version | OpenMPT 1.29.01.00 / libopenmpt 0.5.0 (upgrade first) | ||||
Target Version | OpenMPT 1.29.02.00 / libopenmpt 0.5.1 (upgrade first) | Fixed in Version | OpenMPT 1.29.02.00 / libopenmpt 0.5.1 (upgrade first) | ||
Summary | 0001339: FM voice resets on ended volume envelope | ||||
Description | I guess this is a bug happening because of a workaround for hanging FM voices of some kind? <img src="https://i.ibb.co/7WgxM3f/Bug001.gif" alt="Bug001" border="0"> | ||||
Steps To Reproduce |
| ||||
Additional Information | Let me know if you want the module I found this bug in. And if you want, maybe you can give some critique too on the tune as well if you have time :D | ||||
Tags | No tags attached. | ||||
Has the bug occurred in previous versions? | Maybe back in another test version later than 1.29.00.57, but not futher | ||||
Tested code revision (in case you know it) | |||||
Indeed, portamento between "stopped" notes should not possible, the IT compatibility setting "Do not apply any portamento if no previous note is playing" (enabled by default also in MPTM) takes care of that. Previously this compatibility setting did not affect OPL instruments (accidentally). Of course it's a bit unfortunate that this breaks existing OpenMPT 1.28 behaviour so I will see if anything can be done about that. |
|
Oh okay so it isn't supposed to be like that. I tried to extend the envelope duration by increasing the last node by like 128 ticks, however the envelope doesn't reset. I thought that envelope-carry would have to been set for that to happen, or maybe I know less about Gxx than I think? |
|
Envelope Carry is for notes without portamento. If you want envelopes to retrigger with portamento notes, you have to enable "Compatible Gxx" in the Song Properties dialog. |
|
Something I found out right now in asikwp_and_wito_-_midday.mptm at pattern 22 (https://modarchive.org/index.php?request=view_by_moduleid&query=187116), that might be related to this, is that the Qxx seems to be affected too since it wont retrigger any FM samples. |
|
That's normal - ST3 does the same. You probably just didn't realize it while composing. :) Feel free to compare against OpenMPT 1.28, the drums will also not retrigger there. |
|
Fixed in r13339. I also improved retrigger behaviour for MPTM files. This is controlled through a new playback compatibility setting, which is enabled automatically for newly created files. |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2020-06-11 14:19 | ASIKWUSpulse | New Issue | |
2020-06-11 15:06 | Saga Musix | Assigned To | => Saga Musix |
2020-06-11 15:06 | Saga Musix | Status | new => assigned |
2020-06-11 15:21 | Saga Musix | Note Added: 0004376 | |
2020-06-11 16:38 | ASIKWUSpulse | Note Added: 0004377 | |
2020-06-11 16:46 | Saga Musix | Note Added: 0004378 | |
2020-07-09 13:18 | ASIKWUSpulse | Note Added: 0004396 | |
2020-07-15 20:31 | Saga Musix | Note Added: 0004397 | |
2020-07-25 21:47 | Saga Musix | Note Added: 0004406 | |
2020-07-25 21:47 | Saga Musix | Status | assigned => resolved |
2020-07-25 21:47 | Saga Musix | Resolution | open => fixed |
2020-07-25 21:47 | Saga Musix | Fixed in Version | => OpenMPT 1.29.02.00 / libopenmpt 0.5.1 (upgrade first) |
2020-07-25 21:47 | Saga Musix | Target Version | => OpenMPT 1.29.02.00 / libopenmpt 0.5.1 (upgrade first) |