View Issue Details

IDProjectCategoryView StatusLast Update
0001339OpenMPTGeneralpublic2020-07-09 13:18
ReporterASIKWUSpulse Assigned ToSaga Musix  
PrioritynormalSeverityminorReproducibilityalways
Status assignedResolutionopen 
Product VersionOpenMPT 1.29.01.00 / libopenmpt 0.5.0 (current stable) 
Summary0001339: FM voice resets on ended volume envelope
Description

I guess this is a bug happening because of a workaround for hanging FM voices of some kind?
In this module I created in an early test-build of 1.29 (1.29.00.57) it's visible through the VU-meter quickly going from the VST color to the Normal Instrument color when the volume envelope has reached end with zero volume. An issue of this is that Tone portamento wont work between the notes, like it did in 1.29.00.57, but maybe that behaviour wasn't supposed to be in the first place?

<img src="https://i.ibb.co/7WgxM3f/Bug001.gif&quot; alt="Bug001" border="0">
(pardon the bad quality, but I hope the issue is visible enough)

Steps To Reproduce
  1. Create any kind of OPL-sample
  2. Use it in an instrument with an envelope without any loops and with the last node on a volume-value of zero
  3. Write something in the pattern, try putting two notes after each other with the second having a Tone Portamento FX (Gxx)
  4. If the envelope ends faster than the VU-meters fall, you'll see them change color. The portamento on the second note in the portamento pair wont have any effect.
Additional Information

Let me know if you want the module I found this bug in. And if you want, maybe you can give some critique too on the tune as well if you have time :D

TagsNo tags attached.
Has the bug occurred in previous versions?Maybe back in another test version later than 1.29.00.57, but not futher
Tested code revision (in case you know it)

Activities

Saga Musix

Saga Musix

2020-06-11 15:21

administrator   ~0004376

Indeed, portamento between "stopped" notes should not possible, the IT compatibility setting "Do not apply any portamento if no previous note is playing" (enabled by default also in MPTM) takes care of that. Previously this compatibility setting did not affect OPL instruments (accidentally). Of course it's a bit unfortunate that this breaks existing OpenMPT 1.28 behaviour so I will see if anything can be done about that.

ASIKWUSpulse

ASIKWUSpulse

2020-06-11 16:38

reporter   ~0004377

Oh okay so it isn't supposed to be like that. I tried to extend the envelope duration by increasing the last node by like 128 ticks, however the envelope doesn't reset. I thought that envelope-carry would have to been set for that to happen, or maybe I know less about Gxx than I think?

Saga Musix

Saga Musix

2020-06-11 16:46

administrator   ~0004378

Envelope Carry is for notes without portamento. If you want envelopes to retrigger with portamento notes, you have to enable "Compatible Gxx" in the Song Properties dialog.

ASIKWUSpulse

ASIKWUSpulse

2020-07-09 13:18

reporter   ~0004396

Something I found out right now in asikwp_and_wito_-_midday.mptm at pattern 22 (https://modarchive.org/index.php?request=view_by_moduleid&amp;query=187116), that might be related to this, is that the Qxx seems to be affected too since it wont retrigger any FM samples.

Issue History

Date Modified Username Field Change
2020-06-11 14:19 ASIKWUSpulse New Issue
2020-06-11 15:06 Saga Musix Assigned To => Saga Musix
2020-06-11 15:06 Saga Musix Status new => assigned
2020-06-11 15:21 Saga Musix Note Added: 0004376
2020-06-11 16:38 ASIKWUSpulse Note Added: 0004377
2020-06-11 16:46 Saga Musix Note Added: 0004378
2020-07-09 13:18 ASIKWUSpulse Note Added: 0004396