View Issue Details

IDProjectCategoryView StatusLast Update
0001306OpenMPTPlayback Compatibilitypublic2020-03-26 17:08
ReporterTockingTimBam Assigned To 
PrioritylowSeverityminorReproducibilityalways
Status closedResolutionno change required 
Platformx86OSWindowsOS Version10
Product VersionOpenMPT 1.28.09.00 / libopenmpt 0.4.11 (upgrade first) 
Summary0001306: Wrong sample transpose used for certain multi-sample instrument in edge case involving omitting instrument channel.
Description

I'm having a problem with the intersection of multi-sample instruments, omitting note instruments in the pattern editor, and sample transposition.

So here's my context. I have an .it with a multi-sample instrument. The instrument has two samples. Each sample is transposed to different notes on the sample screen.

Say the instruments is instruments #1, F-5 is assigned to sample A, and F#-5 is assigned to sample B.

In the pattern editor, if I play two notes in sequence in a single channel with the instrument channel set for each note, then each note will use the sample transpose associated with each sample as I would expect. So something like this works fine:

F--5 01 ...</br>
F#-5 01 ...

If, however, I omit the instrument channel for the second note, the second note / second sample will be played with the sample transpose of the first note / sample. So for something like this, the second note, which is played with a second sample (B), is using the sample transpose for the first note (A).

F--5 01 ...</br>
F#-5 .. ...

Confusing me even more, I've only run into this with certain multi-sample instruments, not all of them, and I can't tell what is different between the different instruments.

I've included two tiny .it files, one that has a multi-sample instrument that is exhibiting the behavior, and another that isn't. The instrument with the behavior was originally a much larger multi-sample drum instrument I'd been using. The instrument that isn't exhibiting the behavior is one I just made from scratch for this test.

As an extra point of reference, I opened both files in SchismTracker, and the two instruments used the transposes correctly associated with the samples whether I omitted the instrument number or not.

Steps To Reproduce

Open the .it files and play them. The difference in transposition should be immediately obvious.

TagsNo tags attached.
Attached Files
Has the bug occurred in previous versions?I'm not sure
Tested code revision (in case you know it)

Activities

Saga Musix

Saga Musix

2020-03-26 17:08

administrator   ~0004265

The "failing" file was created with an older OpenMPT version (1.17 RC2), so OpenMPT plays it like that old version would. The other file was freshly created in OpenMPT 1.28, so it doesn't emulate older OpenMPT versions. Go to the Song Properties dialog and click the "Set Defaults" button to upgrade the file to the latest playback behaviour.

Issue History

Date Modified Username Field Change
2020-03-26 13:30 TockingTimBam New Issue
2020-03-26 13:30 TockingTimBam File Added: Multisample_omitInstChannel.zip
2020-03-26 17:08 Saga Musix Note Added: 0004265
2020-03-26 17:08 Saga Musix Status new => closed
2020-03-26 17:08 Saga Musix Resolution open => no change required
2020-03-26 17:08 Saga Musix Description Updated