View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0001269||OpenMPT||[All Projects] Player input plugins (xmp-openmpt, in_openmpt, foo_openmpt)||public||2019-10-11 13:27||2019-11-02 13:59|
|Priority||normal||Severity||minor||Reproducibility||have not tried|
|Product Version||OpenMPT 1.29.00.* (current testing)|
|Target Version||OpenMPT 1.?? (libopenmpt 1.0) (goals)||Fixed in Version|
|Summary||0001269: remove in_winamp|
libopenmpt is now used by the 2 major winamp distributions:
We should consider removing in_winamp from libopenmpt completely.
|Tags||No tags attached.|
|Has the bug occurred in previous versions?|
|Tested code revision (in case you know it)|
I'm not sure this is a good idea at this point. Winamp 5.8 was more or less only released because it was previously leaked, and from what is known there is no intent to further provide any official updates to Winamp 5. This means that Winamp users would have to stick to an unfinished in_mod rewrite with severely reduced functionality (from what I remember, the settings dialog is missing entirely) and very outdated libopenmpt version.
I also couldn't find any repository for the in_openmpt version shipping with WACUP (I suppose it would be at https://github.com/WACUP/ if it existed), meaning that we would either leave people with an outdated version if we stop updating our plugin, or they would have to rely on a closed-source plugin.
I think this only makes sense if we ask dro if he intends to keep in_openmpt updated and open-source, and if it can be used with Winamp 5.666 / 5.8.
To reduce maintenance burden, maybe we could also make our player plugins use a dynamic version of libopenmpt that can be replaced by the user. This way the plugin itself could be treated as an external project that only needs to be updated if there are breaking API changes or new useful features are introduced.
I do not think changing the way we build in_openmpt changes anything with regard to maintenance. To the contrary, splitting would in turn increase support overhead.
Currently available Winamp versions:
Winamp 5.666 Build 3516 (220.127.116.1116) (2013-12-12)
Winamp 5.666 redux Build 3516 (18.104.22.16816) (2013-12-25)
Winamp 5.8 Beta Build 3660 (2018-10-19)
Winamp 5.666 WACUP Build v22.214.171.12446 (2019-10-14)
WACUP provides mostly-up-to-date libopenmpt itself, and all other Winamp branches are most likely dead and unsupported software anyways. I'd rather not continue support for known-dead and known-unsupported other branches.
|2019-10-11 13:27||manx||New Issue|
|2019-10-11 13:27||manx||Status||new => assigned|
|2019-10-11 13:27||manx||Assigned To||=> manx|
|2019-10-11 13:49||Saga Musix||Note Added: 0004106|
|2019-10-11 14:28||manx||Target Version||OpenMPT 1.29 / libopenmpt 0.5 (goals) => OpenMPT 1.?? (libopenmpt 1.0) (goals)|
|2019-10-26 15:50||Saga Musix||Note Added: 0004119|
|2019-11-02 13:59||manx||Note Added: 0004135|