View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0001252||OpenMPT||User Interface||public||2019-08-13 20:21||2019-08-22 21:31|
|Reporter||Fred57||Assigned To||Saga Musix|
|Product Version||OpenMPT 1.28.06.00 / libopenmpt 0.4.6 (upgrade first)|
|Target Version||OpenMPT 1.29.01.00 / libopenmpt 0.5.0 (upgrade first)||Fixed in Version||OpenMPT 1.29.01.00 / libopenmpt 0.5.0 (upgrade first)|
|Summary||0001252: Moving patterns in the order list to the right should insert them right of the target|
I have got for example 5 pattern
|Tags||No tags attached.|
|Has the bug occurred in previous versions?|
|Tested code revision (in case you know it)|
Note that the current behaviour is at least required for duplicating patterns; otherwise shift-dragging a pattern next to itself to duplicate it is not possible. Hence items are always inserted left of the insertion cursor. I'm not a big fan of making it inconsistent between those two edit modes, in particular since it will affect thousands of users that already got used to the current behaviour.
Maybe an option in the settings would help to let user decide what they prefer.
Shift dragging is not a problem, you can detect if the shift key is pressed or not...
Please, don't try to explain to me how to code. Obviously OpenMPT is already checking if the Shift key is pressed this to allow users to duplicate patterns. The point is that shift-dragging requires the current behaviour and only using this behaviour for shift-dragging would make it inconsistent, which would confuse users even more.
Okay, I think I found a middle ground. I will use the new behaviour (inserting to the right rather than to the left) in all cases, but there will be a visual indicator making it clear on which side the patterns will be inserted / duplicated. If someone wants to duplicate patterns right next to their original location, there is already the Duplicate Patterns command.
r11934 modifies the behaviour as outlined in the previous comment. However, since this is quite a big change for users it will not make it into OpenMPT 1.28; this will be a behavioural change in OpenMPT 1.29. Current OpenMPT 1.29 test builds can be obtained from https://builds.openmpt.org/builds/
|2019-08-13 20:21||Fred57||New Issue|
|2019-08-13 20:29||Saga Musix||Summary||Moving a pattern at a position N give the position N-1 => Moving patterns in the order list to the right should insert them right of the target|
|2019-08-14 18:11||Saga Musix||Note Added: 0004012|
|2019-08-14 19:25||Gerirish||Note Added: 0004013|
|2019-08-14 20:57||Fred57||Note Added: 0004014|
|2019-08-14 20:59||Saga Musix||Note Added: 0004015|
|2019-08-22 21:09||Saga Musix||Note Added: 0004017|
|2019-08-22 21:09||Saga Musix||Assigned To||=> Saga Musix|
|2019-08-22 21:09||Saga Musix||Status||new => assigned|
|2019-08-22 21:31||Saga Musix||Status||assigned => resolved|
|2019-08-22 21:31||Saga Musix||Resolution||open => fixed|
|2019-08-22 21:31||Saga Musix||Fixed in Version||=> OpenMPT 1.29.01.00 / libopenmpt 0.5.0 (upgrade first)|
|2019-08-22 21:31||Saga Musix||Target Version||=> OpenMPT 1.29.01.00 / libopenmpt 0.5.0 (upgrade first)|
|2019-08-22 21:31||Saga Musix||Note Added: 0004018|