View Issue Details

IDProjectCategoryView StatusLast Update
0001244OpenMPT[All Projects] Plugins / VSTpublic2019-08-12 18:11
ReporterFred57 Assigned To 
PrioritynoneSeverityminorReproducibilityalways
Status newResolutionopen 
Platformx86OSWindowsOS VersionXP
Product VersionOpenMPT 1.28.06.00 / libopenmpt 0.4.6 (current stable) 
Target VersionFixed in Version 
Summary0001244: Adding one invalid plugin shows superfluous error message
Description

Button 'No' react as 'yes', so there is an error message when the dll is not a plugin.

Steps To Reproduce

plugin Manager / New plugin
choose any dll file which is not a plugin
question : Do you want to open the plugin navitely ?
answer : 'no'
error message... whereas there should not be one here.

If I scan the new plugins, and say 'no', there is no problem with this window.

TagsNo tags attached.
Has the bug occurred in previous versions?yes
Tested code revision (in case you know it)

Activities

Saga Musix

Saga Musix

2019-08-10 22:05

administrator   ~0003993

The error message that is shown is a summary for all plugins that have been tried. I guess what you suggest is that this error message should not be shown if only one plugin was tried to be loaded and the user already acknowledged that it's not a valid plugin?

Fred57

Fred57

2019-08-10 22:50

reporter   ~0003994

yes, the error message shouldn't be shown as I don't want to try the native one ;)
if I say yes and the native one is not working, and only in this case, I should see this error message
If the error message is shown that's could proove that even I say no, this is doing a yes action (to verify with a native one which is working, I think it will be add in the plugins even if I say no, but I don't have a plugin like that I could test with)

Saga Musix

Saga Musix

2019-08-12 18:11

administrator   ~0004004

Okay. In that case, don't expect this to be fixed anytime soon. It would require changing an unreasonable amount of code for a minor annoyance (the code that displays the first message is in a completely different part of the program than the code that shows the summary in the second message, and the latter doesn't "know" anything about the former). Just don't load invalid plugins for now. ;)

Issue History

Date Modified Username Field Change
2019-08-10 21:59 Fred57 New Issue
2019-08-10 22:05 Saga Musix Status new => feedback
2019-08-10 22:05 Saga Musix Note Added: 0003993
2019-08-10 22:50 Fred57 Note Added: 0003994
2019-08-10 22:50 Fred57 Status feedback => new
2019-08-12 18:11 Saga Musix Priority low => none
2019-08-12 18:11 Saga Musix Summary Do you want to open the plugin navitely ? : Button 'No' is not working as this should => Adding one invalid plugin shows superfluous error message
2019-08-12 18:11 Saga Musix Note Added: 0004004