View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0001236OpenMPTlibopenmptpublic2019-07-07 13:352019-07-30 20:30
ReporterSajadi Assigned ToSaga Musix  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Platformx64OSWindowsOS Version8
Product VersionOpenMPT 1.28.05.00 / libopenmpt 0.4.5 (upgrade first) 
Target VersionOpenMPT 1.29.01.00 / libopenmpt 0.5.0 (upgrade first)Fixed in VersionOpenMPT 1.29.01.00 / libopenmpt 0.5.0 (upgrade first) 
Summary0001236: Sample swap from non-looped sample doesn't work in MOD
Description

Reporting an issue which also happens with 2016-x-x builds.

Compared to the normal playback routine of XMPlay, the libopenmpt plugin for XMPlay has trouble to play Mr Man's Sequential track... elements of the song are not played back but get played back without the plugin - for example 1:34-1:37 misses song elements which can be heard in XMPlay without the plugin.

link for the song: http://amp.dascene.net/downmod.php?index=48769

Steps To Reproduce

1) download the song
2) compare the file in XMPlay - play it one time with and then without the libopenmpt plugin
3) result is song elements are shortened/cut/missing with the plugin and expanded without the plugin

TagsNo tags attached.
Attached Files
sequential4.final.zip (111,190 bytes)
Has the bug occurred in previous versions?yes
Tested code revision (in case you know it)happens with the 2016 builds of the plugin too

Activities

Saga Musix

Saga Musix

2019-07-07 16:26

administrator   ~0003977

Seems like on-the-fly sample swapping also works when swapping from a non-looping sample. There is a simple fix but it will have to be tested thoroughly on lots of other MODs to avoid breaking anything.

PS: While XMPlay's playback is very good, it's not the holy grail for ProTracker MOD files and doesn't support some ProTracker quirks. 4-channel MOD playback should be compared against ProTracker 2.3d (or bubsy's ProTracker port for Windows/macOS) and not XMPlay. In this case the results would be the same but I just want to point this out for future bug reports.
Saga Musix

Saga Musix

2019-07-30 20:29

administrator   ~0003981

Last edited: 2019-07-30 20:30

r11844 (libopenmpt 0.5 only) should fix this, builds should be available from https://builds.openmpt.org/builds/ in a few hours. Please let me know if any ProTracker MOD files sound strange now.

Issue History

Date Modified Username Field Change
2019-07-07 13:35 Sajadi New Issue
2019-07-07 13:35 Sajadi File Added: sequential4.final.zip
2019-07-07 13:37 Sajadi Severity major => minor
2019-07-07 16:26 Saga Musix Note Added: 0003977
2019-07-07 16:26 Saga Musix Assigned To => Saga Musix
2019-07-07 16:26 Saga Musix Status new => assigned
2019-07-14 18:04 Saga Musix Summary song elements missing from Mr Man's Sequential track when using the libopenmpt plugin for XMPlay => Sample swap from non-looped sample doesn't work in MOD
2019-07-30 20:29 Saga Musix Note Added: 0003981
2019-07-30 20:30 Saga Musix Status assigned => resolved
2019-07-30 20:30 Saga Musix Resolution open => fixed
2019-07-30 20:30 Saga Musix Fixed in Version => OpenMPT 1.29.01.00 / libopenmpt 0.5.0 (upgrade first)
2019-07-30 20:30 Saga Musix Target Version => OpenMPT 1.29.01.00 / libopenmpt 0.5.0 (upgrade first)
2019-07-30 20:30 Saga Musix Note Edited: 0003981