0001228: "Convert existing samples to instruments first?" dialog creates one additional dummy sample.

ID	Project	Category	View Status	Date Submitted	Last Update

0001228	OpenMPT	User Interface	public	2019-06-01 07:48	2019-06-02 21:06

Reporter	StinkerB06	Assigned To
Priority	normal	Severity	minor	Reproducibility	always
Status	closed	Resolution	no change required
Platform	x64	OS	Windows	OS Version	10
Product Version	OpenMPT 1.28.05.00 / libopenmpt 0.4.5 (upgrade first)

Summary	0001228: "Convert existing samples to instruments first?" dialog creates one additional dummy sample.
Description	If you select "Yes" or "No" in the aforementioned pop-up dialog, a new sample gets created out of nowhere. For example, if your module has 4 samples that occupy sample slots 1~4, and you decide to convert them to instruments, it creates sample slot 5. If you select "Yes", then that 5th sample also gets converted to an instrument.
Steps To Reproduce	Create a new module in any format that supports instruments (MPTM, IT, or XM). Add some samples to the module. It doesn't matter how many. Go to the "Instruments" tab and click "New instrument". In the following dialog, click "Yes" or "No", but not "Cancel". Go to the "Samples" tab. You'll notice that it automatically created a new sample.
Additional Information	I don't have anything else to say about the bug/issue itself, but I'm not sure what Priority this should be kept at.
Tags	No tags attached.

Has the bug occurred in previous versions?	Yes.
Tested code revision (in case you know it)

Date Modified	Username	Field	Change
2019-06-01 07:48	StinkerB06	New Issue
2019-06-02 21:06	Saga Musix	Note Added: 0003959
2019-06-02 21:06	Saga Musix	Status	new => closed
2019-06-02 21:06	Saga Musix	Resolution	open => no change required

Saga Musix 2019-06-02 21:06 administrator ~0003959	This is by design and not special to this situation - any newly inserted instrument will have an empty sample slot assigned to it. In particular, "Convert existing samples to instrument first?" adds a new instrument, and this new instrument is assigned to an - at this point empty sample slot.