View Issue Details

IDProjectCategoryView StatusLast Update
0001223OpenMPT[All Projects] Playback Compatibilitypublic2019-10-27 20:00
Reporterraina Assigned ToSaga Musix  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
PlatformOpenMPT/libopenmptOSWindows/AndroidOS Version10/9
Product VersionOpenMPT 1.28.04.00 / libopenmpt 0.4.4 (upgrade first) 
Target VersionOpenMPT 1.29 / libopenmpt 0.5 (goals)Fixed in VersionOpenMPT 1.29 / libopenmpt 0.5 (goals) 
Summary0001223: Notes in .XM get triggered after key-off when doing portamento-to-note without instrument number
Description

In the attached module, on channels 1-2 of pattern 2 in position 7 (for example), the F and A notes have their volume envelopes reset when they should only be doing portamento-to-note on the decaying notes from the previous pattern.

Secondly, if I start playback from this pattern, the notes are still very much audible when they really shouldn't have been triggered at all. The only way I can silence them is by deleting the prior positions 0-6 placing pattern 2 at the beginning where there can't be a prior instrument reference. However if this behavior is intentional, I do see the workflow convenience benefits in it.

TagsNo tags attached.
Has the bug occurred in previous versions?I've heard this playback error on several Android music players. Droidsound-E reports libopenmpt v0.4.3
Tested code revision (in case you know it)

Activities

raina

raina

2019-04-24 07:59

reporter  

introtune_retrigmx.zip (36,513 bytes)
Saga Musix

Saga Musix

2019-04-24 11:14

administrator   ~0003930

Secondly, if I start playback from this pattern, the notes are still very much audible when they really shouldn't have been triggered at all.

(lib)OpenMPT keeps track of active notes using a simplified parser when jumping around in the module but I guess this parser might not be taking Key-Off effects into account. I'll look into it (and the other issue).

Saga Musix

Saga Musix

2019-04-24 19:15

administrator   ~0003931

Alright, the easy part (hanging notes when seeking) is fixed in r11567.

Saga Musix

Saga Musix

2019-10-27 20:00

administrator   ~0004124

The playback bug is fixed as of r12254, updated builds will be available from https://builds.openmpt.org/builds/ soon.

Issue History

Date Modified Username Field Change
2019-04-24 07:59 raina New Issue
2019-04-24 07:59 raina File Added: introtune_retrigmx.zip
2019-04-24 08:01 raina OS Android => Windows/Android
2019-04-24 08:01 raina OS Version 9 => 10/9
2019-04-24 08:01 raina Platform Various players on => OpenMPT/libopenmpt
2019-04-24 11:12 Saga Musix Assigned To => Saga Musix
2019-04-24 11:12 Saga Musix Status new => assigned
2019-04-24 11:14 Saga Musix Note Added: 0003930
2019-04-24 19:15 Saga Musix Note Added: 0003931
2019-10-27 20:00 Saga Musix Note Added: 0004124
2019-10-27 20:00 Saga Musix Status assigned => resolved
2019-10-27 20:00 Saga Musix Resolution open => fixed
2019-10-27 20:00 Saga Musix Fixed in Version => OpenMPT 1.29 / libopenmpt 0.5 (goals)
2019-10-27 20:00 Saga Musix Target Version => OpenMPT 1.29 / libopenmpt 0.5 (goals)