View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0001127||OpenMPT||[All Projects] Player input plugins (xmp-openmpt, in_openmpt, foo_openmpt)||public||2018-06-09 22:51||2018-06-26 19:03|
|Target Version||Fixed in Version|
|Summary||0001127: Sample texts in Impulsetracker modules should be exposed in the foo_openmpt message tag|
It seems that currently, in the foo_openmpt message tag, for Impulsetracker modules, comments are displayed, and if those aren't found, instrument texts are displayed. I've seen some old modules that will actually write comments in samples rather than instruments, so the message tag only shows instrument names. I believe that sample tags should be included along with instruments in the foo_openmpt message tag.
|Tags||No tags attached.|
|Has the bug occurred in previous versions?|
|Tested code revision (in case you know it)|
If the song message is empty, we fall back to using the instrument names, if in turn they are completely empty, we fall back to using sample names. Although this heuristics work for most modules, it obviously cannot work for all modules, and I do not see an easy way to solve this.
It might be the case that the module in question only contains whitespace characters in the instrument names, and we could probably include that aspect in the heuristics.
Can you name/provide specific modules where the current heuristic fails?
Yes, (-DF-RND.IT. https://www.dropbox.com/s/gyn60pu6ej569jj/%28-DF-RND.IT?dl=1
It is more common in IT files to use sample texts rather than instrument texts for a song message, but of course this is not true for all modules. I guess we have to expose both texts if no comments are found in order to support both possible scenarios. The foobar plugin should probably also somehow expose the sample/instrument texts separately if it doesn't do so already, just like xmp-openmpt.
Update. Here is a more permanent link to the test case I provided in earlier comments. ftp://ftp.modland.com/pub/modules/Impulsetracker/Corpse/coop-Dark%20Freddy/rainy%20day.it
|2018-06-09 22:51||Slender||New Issue|
|2018-06-10 05:11||manx||Assigned To||=> manx|
|2018-06-10 05:11||manx||Status||new => feedback|
|2018-06-10 05:11||manx||Note Added: 0003548|
|2018-06-10 08:03||Slender||Note Added: 0003549|
|2018-06-10 08:03||Slender||Status||feedback => assigned|
|2018-06-12 13:19||Saga Musix||Note Added: 0003551|
|2018-06-26 19:03||Slender||Note Added: 0003569|