View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0001096OpenMPTlibopenmptpublic2018-03-04 13:432018-12-23 13:22
Reportermanx Assigned Tomanx  
PrioritylowSeveritytweakReproducibilityalways
Status resolvedResolutionfixed 
Product VersionOpenMPT 1.28.00.* (old testing) 
Fixed in VersionOpenMPT 1.28.01.00 / libopenmpt 0.4.0 (upgrade first) 
Summary0001096: Use ATL for MediaFoundation COM pointers
Description

Using proper smart pointers would simplify the code considerably.
ATL is a header-only library since VS2013.
However, ATL is shipped with Visual Studio only and not included in MinGW-W64. This would limit MediaFoundation sample import to MSVC builds in libopenmpt. Given that we can freely use libmpg123 nowadays, this would not be a severe regression, IMHO.

TagsNo tags attached.
Has the bug occurred in previous versions?
Tested code revision (in case you know it)

Relationships

related to 0001099 resolvedmanx Remove MediaFoundation support in libopenmpt 

Activities

manx

manx

2018-03-04 13:46

administrator   ~0003454

Also, MediaFoundation is not even enabled in the default libopenmpt configuration at the moment.
Saga Musix

Saga Musix

2018-03-04 20:07

administrator   ~0003455

Given the availability of both mpg123 (default) and minimp3 (a very usable fallback), I am actually not really in favor of having MF support enabled in libopenmpt. It just adds more code paths that will be barely ever exercised.
manx

manx

2018-03-04 20:17

administrator   ~0003456

It's only even enabled at all in the libopenmpt-full build, which is neither built nor shipped by default anyway.
manx

manx

2018-03-04 20:18

administrator   ~0003457

r9834
manx

manx

2018-03-04 20:21

administrator   ~0003458

We could still remove MeidaFoundation support completely in libopenmpt, which would remove yet another set of build system quirks.

Issue History

Date Modified Username Field Change
2018-03-04 13:43 manx New Issue
2018-03-04 13:43 manx Status new => assigned
2018-03-04 13:43 manx Assigned To => manx
2018-03-04 13:46 manx Note Added: 0003454
2018-03-04 20:07 Saga Musix Note Added: 0003455
2018-03-04 20:17 manx Note Added: 0003456
2018-03-04 20:18 manx Status assigned => resolved
2018-03-04 20:18 manx Resolution open => fixed
2018-03-04 20:18 manx Fixed in Version => libopenmpt 0.4 (goals)
2018-03-04 20:18 manx Note Added: 0003457
2018-03-04 20:21 manx Note Added: 0003458
2018-03-05 13:30 manx Relationship added related to 0001099
2018-12-23 13:22 Saga Musix Fixed in Version libopenmpt 0.4 (goals) => OpenMPT 1.28.01.00 / libopenmpt 0.4.0 (upgrade first)