View Issue Details

IDProjectCategoryView StatusLast Update
0000980OpenMPT[All Projects] User Interfacepublic2019-05-19 18:24
ReporterZerroDeNullAssigned ToSaga Musix 
PrioritynormalSeverityfeatureReproducibilitysometimes
Status assignedResolutionopen 
PlatformLaptopOSWindowsOS Version8.1 64 Bit
Product VersionOpenMPT 1.27.00.* (old testing) 
Target VersionFixed in Version 
Summary0000980: Shortcut Display in Tool-Tip
Description

An option in the Settings to display the Shortcuts to UI-Elements as all the Buttons and so on.
Many applications provide such an option to eneable od disable tool-tips with an option to display or hide the key combination of its shortcut.
I my self often enable such options and feel good with it, even if i remember the shortcuts after some time.
May this would also help new users to learn and get into openModPlug,
I even think this could be a step towards openEcoModPlug, just because less people would print out shortcut tables and in that way they would save some wood and this may gives a chance to new generations to keep on tracking.
I also think it could help users if they play around with custom shortcuts, here i would have a vision of normal slightly yellow tooltips with the name of the element and then each shortcut on a own line below the element name, but if there is a shortcut conflict the conflicting shortcut line is displayed slightly red within the slightly yellow tooltip.

Steps To Reproduce

open settings
search the new option hide or display tooltips
search the new option hide or display shortcuts in tooltips
check them as you like
put your mouse on a ui element or select it by keyboardcommands
wait some time
a tooltip will open with the name of the element and on each line its shortcut if there are multiple shortcuts and conflicting shortcuts will be marked.

Additional Information

many times i thoght about that
i think... if i remember correctly .. it is jeskola buzz with the F-Keys in the tooltips.
it happens many times when i see the tooltip in ModPlug that i think to my self "ah no it was the other one with the F-Keys in the tooltips".... i dont know why this comes always to y mind when i see this tooltips, actualy maybe because i try to customize them ;)

how ever i already start to feel ashamed about all the may minor issues i have opened here, but i realy do not think they are all bad at all, may you sleep a bit about it and let it roll in your head and ... hey, may you like one or an other idea too... ModPlug is great any way ;)

Thanks :)

TagsNo tags attached.
Has the bug occurred in previous versions?it is not a bug
Tested code revision (in case you know it)

Activities

Saga Musix

Saga Musix

2017-06-17 15:53

administrator   ~0003085

There is no need to be an option - as in, there would be no single reason to disable this. However, many of the tooltips are not generated programmatically so it's currently simply not possible to add the shortcuts to those tooltips.

zoltarx

zoltarx

2019-05-07 08:38

reporter   ~0003939

I would vote for that feature also. It will be very nice and useful for beginners to see shortcut and be able to see "Play Pattern (F7)" in a tooltip. Otherwise one may stuck with continously clicking Setup icon to review those shortcuts.

If tooltips are not generated programmatically, maybe there is a possibility to update them on shortcut definition change?



MPT1.png (28,937 bytes)
MPT1.png (28,937 bytes)
MPT2.png (26,584 bytes)
MPT2.png (26,584 bytes)
Saga Musix

Saga Musix

2019-05-07 17:21

administrator   ~0003940

maybe there is a possibility to update them on shortcut definition change

This is exactly what implies generating them programmatically.

zoltarx

zoltarx

2019-05-08 14:14

reporter   ~0003941

Thank you for answering, specially because this issue is rather old.

I am a programmer and wish to help but I am not specialized in C++ although I have some knowledge about it and WinAPI. It seems to be good idea to generate hints / tooltips programmatically.

https://stackoverflow.com/questions/992919/how-to-set-up-win32-tooltips-control-with-dynamic-unicode-text

Saga Musix

Saga Musix

2019-05-08 18:24

administrator   ~0003942

The code you referred to is already being used (in some way or another), the reason there are no tips for toolbar buttons at the moment is that it didn't quite work the last time I tried and I didn't really have any motivation to pursue this issue any further.

Saga Musix

Saga Musix

2019-05-08 18:28

administrator   ~0003943

Speaking of which, I just looked at the code and figured out why it was misbehaving. I'll start by updating the tooltips in the pattern editor.

Saga Musix

Saga Musix

2019-05-08 19:14

administrator   ~0003944

I have now implemented tooltips for the icons in the pattern, sample and instrument editor.
r11576 or later will soon be available for testing at https://builds.openmpt.org/builds/auto/openmpt/bin.win64/1.28/

Saga Musix

Saga Musix

2019-05-19 18:24

administrator   ~0003945

As of r11583, tooltips are also shown for the main toolbar.

Issue History

Date Modified Username Field Change
2017-06-17 14:26 ZerroDeNull New Issue
2017-06-17 15:53 Saga Musix Note Added: 0003085
2019-05-07 08:38 zoltarx File Added: MPT1.png
2019-05-07 08:38 zoltarx File Added: MPT2.png
2019-05-07 08:38 zoltarx Note Added: 0003939
2019-05-07 17:21 Saga Musix Note Added: 0003940
2019-05-08 14:14 zoltarx Note Added: 0003941
2019-05-08 18:24 Saga Musix Note Added: 0003942
2019-05-08 18:28 Saga Musix Note Added: 0003943
2019-05-08 18:28 Saga Musix Assigned To => Saga Musix
2019-05-08 18:28 Saga Musix Status new => assigned
2019-05-08 19:14 Saga Musix Note Added: 0003944
2019-05-19 18:24 Saga Musix Note Added: 0003945