View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0000906||OpenMPT||Plugins / VST||public||2017-01-03 21:38||2017-02-09 01:36|
|Reporter||triplefox||Assigned To||Saga Musix|
|Product Version||OpenMPT 1.26.07.00 / libopenmpt 0.2-beta20.3 (upgrade first)|
|Target Version||OpenMPT 1.26.08.00 / libopenmpt 0.2-beta20.5 (upgrade first)||Fixed in Version||OpenMPT 1.26.08.00 / libopenmpt 0.2-beta20.5 (upgrade first)|
|Summary||0000906: ValhallaDSP Reverb plugins are muted early when they extend the playback time of sampler instruments|
OpenMPT appears to be too aggressive in muting instruments when combined with effects plugins; the behavior is correct when plugins are the sound source, but not when using the sampler.
|Steps To Reproduce|
To reproduce, open a new MPTM, apply any reverb or delay plugin with a long time to a sampled instrument, and play a single note, either in preview or in a pattern. The sound will cut partway through the reverb tail. Additionally, the tail can be heard continuing where it left off when a second note is played.
|Tags||No tags attached.|
|Has the bug occurred in previous versions?||Yes|
|Tested code revision (in case you know it)|
Is the plugin you use by any chance Valhalla Shimmer? Because that's the only plugin I know that exhibits exactly this behaviour.
All Valhalla plugins I tested exhibit it(UberMod, VintageVerb). Now I am properly testing other plugins that I use more rarely, and yes, my impression that it affected all of them was wrong. embarrassment
After further investigation, Valhalla Shimmer sets the "effFlagsNoSoundInStop" flag, which tells the host that it will not produce any output if the input is silence. So this particular plugin is buggy, as it allows us to remove unnecessary render calls. I've notified the plugin author. Of course it's possible that other reverb plugins by other authors also set this flag, but it would seem weird to me if so many plugin authors would set this flag that is supported by almost no hosts.
I talked to Sean from ValhallaDSP and he said that he confirmed that he's using an old versions of JUCE (which is the source of this bug) and cannot upgrade it for now. Until the user can manually toggle this setting, I have completely disabled silence detection for VST plugins. You can grab a r7553 or later from https://buildbot.openmpt.org/ to test this.
|2017-01-03 21:38||triplefox||New Issue|
|2017-01-03 21:38||triplefox||Tag Attached: instrument|
|2017-01-03 21:38||triplefox||Tag Attached: instrument preview|
|2017-01-03 21:59||Saga Musix||Note Added: 0002821|
|2017-01-03 22:00||Saga Musix||Note Edited: 0002821|
|2017-01-03 22:05||triplefox||Note Added: 0002823|
|2017-01-03 22:16||Saga Musix||Note Added: 0002824|
|2017-01-03 22:16||Saga Musix||Note Edited: 0002824|
|2017-01-03 22:16||Saga Musix||Summary||Effects plugins are muted early when they extend the playback time of sampler instruments => ValhallaDSP Reverb plugins are muted early when they extend the playback time of sampler instruments|
|2017-01-03 22:20||triplefox||Note Added: 0002825|
|2017-01-04 00:33||Saga Musix||Tag Detached: instrument|
|2017-01-04 00:33||Saga Musix||Tag Detached: instrument preview|
|2017-01-04 00:33||Saga Musix||Category||General => Plugins / VST|
|2017-02-02 22:09||Saga Musix||Assigned To||=> Saga Musix|
|2017-02-02 22:09||Saga Musix||Status||new => assigned|
|2017-02-02 22:09||Saga Musix||Status||assigned => feedback|
|2017-02-02 22:09||Saga Musix||Note Added: 0002861|
|2017-02-03 00:58||Saga Musix||Target Version||=> OpenMPT 1.26.08.00 / libopenmpt 0.2-beta20.5 (upgrade first)|
|2017-02-09 01:36||Saga Musix||Status||feedback => resolved|
|2017-02-09 01:36||Saga Musix||Resolution||open => fixed|
|2017-02-09 01:36||Saga Musix||Fixed in Version||=> OpenMPT 1.26.08.00 / libopenmpt 0.2-beta20.5 (upgrade first)|