View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0000725 | OpenMPT | General | public | 2015-11-11 22:56 | 2015-11-13 14:23 |
Reporter | Saga Musix | Assigned To | manx | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | resolved | Resolution | fixed | ||
Product Version | OpenMPT 1.25.03.00 / libopenmpt 0.2-beta15 (upgrade first) | ||||
Target Version | OpenMPT 1.25.04.00 / libopenmpt 0.2-beta16 (upgrade first) | Fixed in Version | OpenMPT 1.25.04.00 / libopenmpt 0.2-beta16 (upgrade first) | ||
Summary | 0000725: MP3 encoder misses first few samples due to malformed ID3v2.4 tags | ||||
Description | The MP3 ACM encoder seems to throw away the first few samples fed into it; Having some sound with a sharp attack on the first row of the song demonstrates this best: The attack will be lost with the ACM encoder. | ||||
Tags | No tags attached. | ||||
Attached Files | |||||
Has the bug occurred in previous versions? | |||||
Tested code revision (in case you know it) | |||||
Should be fixed in r5757. |
|
After the fix I start to wonder if this was actually caused by OpenMPT at all or if it's a bug in LAME ACM... now there is some additional silence at the start but the click is still missing, compared to other encoders (see attached file). |
|
r5757 did not actually fix (or even change) anything at all. Looks like LAME ACM does not even set nCodecDelay. I (we?) probably got confused with the test outputs yesterday. |
|
Ok, I rendered the testcase using libmp3lame VBR (i.e. with LAME header), libmp3lame CBR (without LAME header), LAME ACM CBR and OpenMPT native WAVE output. Versions tested: |
|
I seem to have found the key to this issue: At least with the ACM codec, there seems to be a difference in the exported result depending on whether ID3 tags are embedded or not. |
|
Fixed in r5763 |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2015-11-11 22:56 | Saga Musix | New Issue | |
2015-11-12 10:17 | manx | Assigned To | => manx |
2015-11-12 10:17 | manx | Status | new => assigned |
2015-11-12 10:17 | manx | Note Added: 0002176 | |
2015-11-12 23:35 | Saga Musix | Note Added: 0002177 | |
2015-11-12 23:36 | Saga Musix | File Added: kick.7z | |
2015-11-13 09:35 | manx | Note Added: 0002179 | |
2015-11-13 10:16 | manx | File Added: bug725-manx-1.7z | |
2015-11-13 10:21 | manx | Note Added: 0002180 | |
2015-11-13 13:11 | Saga Musix | Note Added: 0002182 | |
2015-11-13 14:23 | Saga Musix | Note Added: 0002185 | |
2015-11-13 14:23 | Saga Musix | Status | assigned => resolved |
2015-11-13 14:23 | Saga Musix | Resolution | open => fixed |
2015-11-13 14:23 | Saga Musix | Product Version | => OpenMPT 1.25.03.00 / libopenmpt 0.2-beta15 (upgrade first) |
2015-11-13 14:23 | Saga Musix | Fixed in Version | => OpenMPT 1.25.04.00 / libopenmpt 0.2-beta16 (upgrade first) |
2015-11-13 14:23 | Saga Musix | Target Version | => OpenMPT 1.25.04.00 / libopenmpt 0.2-beta16 (upgrade first) |
2015-11-13 14:23 | Saga Musix | Summary | MP3 ACM encoder misses first few samples => MP3 encoder misses first few samples due to malformed ID3v2.4 tags |