View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0000657 | OpenMPT | Feature Request | public | 2015-03-08 10:17 | 2015-03-20 15:50 |
Reporter | goluigi | Assigned To | Saga Musix | ||
Priority | normal | Severity | minor | Reproducibility | N/A |
Status | resolved | Resolution | fixed | ||
Platform | x64 | OS | Windows | OS Version | 7 |
Product Version | OpenMPT 1.24.02.00 / libopenmpt 0.2-beta10 (upgrade first) | ||||
Target Version | OpenMPT 1.24.03.00 / libopenmpt 0.2-beta11 (upgrade first) | Fixed in Version | OpenMPT 1.24.03.00 / libopenmpt 0.2-beta11 (upgrade first) | ||
Summary | 0000657: [IT] keep track of current Xxx, Zxx, and S90/S91 values when starting playback of a song in the middle of the song | ||||
Description | OpenMPT should keep track of all the values for these channel commands (I may have missed a few) when starting playback in the middle of the song. This already happens with the Mxx (channel volume effect), OpenMPT keeps track of the current value for Mxx and uses the current value at a certain point in a song. This should also happen for the commands I mentioned and maybe some other channel commands that I missed. | ||||
Steps To Reproduce | https://www.dropbox.com/s/paob7pc0b9lnxkz/memory%20test.it?dl=1 Here is a file that demonstrates what I am talking about. Play it normally first and you'll notice it plays as intended, the pan is shifted 0x20 to the left, the cutoff filter is set to 0x66, and the channel volume is set to 0x11. Now play the song from row 3 or after the commands. Only the 0x11 channel volume effect is emulated and not the filter or pan. | ||||
Tags | No tags attached. | ||||
Has the bug occurred in previous versions? | |||||
Tested code revision (in case you know it) | |||||
This post was accidentally reposted three times because I initially attached a file to this but the file type was invalid and so I edited the file out and resubmitted, thinking that it would only create one post but it created three. |
|
I definitely agree on the panning part, but Zxx is difficult because of the blackbox nature of MIDI messages - for example, if Zxx is configured to send MIDI CCs to a VST plugin, which of them would need to be sent to the plugin? All of them? Only the last one? Does it matter that the messages are suddenly called at the same time? Plus, sending messages to plugins is of course relatively expensive. This makes Zxx state bookkeeping difficult. In general, if you use Zxx for filters only, I'd suggest to try using the filter settings in the instrument properties (default cutoff and resonance values). |
|
oh wow for some reason i didn't realise you could set cutoff values higher than the default value i thought it like scaled from 0 to where you set it (wtf?????) haha okay that works. but yeah, what I said about Xxx and S91 is still valid. |
|
r4901 adds S91/S90 and panning command handling to the seeking code. |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2015-03-08 10:17 | goluigi | New Issue | |
2015-03-08 10:27 | goluigi | Note Added: 0001966 | |
2015-03-08 14:24 | Saga Musix | Note Added: 0001967 | |
2015-03-08 20:21 | goluigi | Note Added: 0001968 | |
2015-03-10 00:15 | Saga Musix | Assigned To | => Saga Musix |
2015-03-10 00:15 | Saga Musix | Status | new => assigned |
2015-03-20 15:50 | Saga Musix | Note Added: 0002017 | |
2015-03-20 15:50 | Saga Musix | Status | assigned => resolved |
2015-03-20 15:50 | Saga Musix | Resolution | open => fixed |
2015-03-20 15:50 | Saga Musix | Fixed in Version | => OpenMPT 1.24.03.00 / libopenmpt 0.2-beta11 (upgrade first) |
2015-03-20 15:50 | Saga Musix | Target Version | => OpenMPT 1.24.03.00 / libopenmpt 0.2-beta11 (upgrade first) |