View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0000643 | OpenMPT | File Format Support | public | 2015-02-03 19:57 | 2016-02-28 09:16 |
Reporter | RyanBram | Assigned To | Saga Musix | ||
Priority | low | Severity | feature | Reproducibility | have not tried |
Status | resolved | Resolution | fixed | ||
Platform | All platform | OS | All OS | OS Version | All version |
Product Version | OpenMPT 1.24.01.00 / libopenmpt 0.2-beta8 (upgrade first) | ||||
Target Version | OpenMPT 1.25.04.00 / libopenmpt 0.2-beta16 (upgrade first) | Fixed in Version | OpenMPT 1.25.04.00 / libopenmpt 0.2-beta16 (upgrade first) | ||
Summary | 0000643: Native support of MO3 | ||||
Description | Current OpenMPT support for unmo3 is provided by binary blob from Ian Luck. | ||||
Additional Information |
| ||||
Tags | No tags attached. | ||||
Has the bug occurred in previous versions? | yes | ||||
Tested code revision (in case you know it) | |||||
In case you haven't noticed, I have contributed to the opensource unmo3 myself, and I can tell you that the code quality is so abysmal (probably because it's just a proof of concept) and full of security issues that rewriting a decoder from scratch would be a better choice. Plus, the open-source version of unmo3 doesn't actually do any of the MP3 or OGG decoding, so it's incomplete too. |
|
I also favour a new from scratch native parser for mo3 in OpenMPT/libopenmpt instead of completing and fixing the open source unmo3 library. The former would probably also be less work in total. |
|
Thank you for your detailed explanation. Do you have any plan to developed mo3 codec from scratch in any near future? or If the answer for the former question is "no", my hope is you don't mark this report as won't fix and let it be open until somebody else take care for this report. Best regards |
|
There are no plans to do so from my side. |
|
I currently do not have any plans for working on this either, but I do consider the feature request valid and would also like to see native mo3 support sometime in the future. |
|
I never work with mo3 files, but I double-clicked on one from a CD game to listen to the music, and OpenMPT opened it without a hitch. It was pretty basic (like a MOD file) but I was able to listen to the track. So apparently SOME compatibility is available by openMPT. Let it be known that mo3 files might at least be accessible by openMPT. |
|
The focus in the feature request is on native, built-in support for MO3 files without relying on the closed-source unmo3.dll/unmo3.so, especially in the context of libopenmpt. For OpenMPT it's less of an issue, but using the closed-source unmo3 can cause licensing problems when wanting to use a completely free library, and in general libraries depending on other 3rd party libraries are always a big hassle. |
|
In a state of coding frenzy I started working on an MO3 loader last night, and pretty much everything apart from sample loading is done. |
|
Glad to hear that. |
|
Decoder implementation is now complete. Integration into the build system (mostly #defining some flags and searching for libmpg123) for libopenmpt is still left to do for the next major release. |
|
I implemented most of the build system changes for libopenmpt on the major desktop systems. Android, Emscripten are not done yet. |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2015-02-03 19:57 | RyanBram | New Issue | |
2015-02-03 20:02 | Saga Musix | Note Added: 0001945 | |
2015-02-03 20:12 | manx | Note Added: 0001946 | |
2015-02-03 21:04 | RyanBram | Note Added: 0001947 | |
2015-02-03 21:14 | Saga Musix | Note Added: 0001948 | |
2015-02-03 21:19 | manx | Note Added: 0001949 | |
2015-02-03 21:22 | manx | Summary | Native support of MO3 through open source unmo3 => Native support of MO3 |
2015-02-03 21:24 | manx | Description Updated | |
2015-02-03 21:24 | manx | Additional Information Updated | |
2015-02-03 21:25 | manx | Status | new => confirmed |
2015-02-03 21:32 | Saga Musix | Priority | normal => low |
2015-03-17 01:13 | harbinger | Note Added: 0002006 | |
2015-03-17 01:16 | Saga Musix | Note Added: 0002007 | |
2015-11-06 13:43 | Saga Musix | Note Added: 0002170 | |
2015-11-06 13:43 | Saga Musix | Assigned To | => Saga Musix |
2015-11-06 13:43 | Saga Musix | Status | confirmed => assigned |
2015-11-06 15:51 | RyanBram | Note Added: 0002171 | |
2015-11-16 22:37 | Saga Musix | Note Added: 0002186 | |
2015-11-16 22:37 | Saga Musix | Status | assigned => resolved |
2015-11-16 22:37 | Saga Musix | Resolution | open => fixed |
2015-11-16 22:37 | Saga Musix | Fixed in Version | => OpenMPT 1.25.04.00 / libopenmpt 0.2-beta16 (upgrade first) |
2015-11-16 22:37 | Saga Musix | Target Version | => OpenMPT 1.25.04.00 / libopenmpt 0.2-beta16 (upgrade first) |
2016-02-28 09:16 | manx | Note Added: 0002270 |