View Issue Details

IDProjectCategoryView StatusLast Update
0000474OpenMPTPlayback Compatibilitypublic2014-01-18 17:19
Reporterabbeyj Assigned ToSaga Musix  
Status resolvedResolutionfixed 
Platformx64OSWindowsOS Version7
Product VersionOpenMPT (upgrade first) 
Target VersionOpenMPT (upgrade first)Fixed in VersionOpenMPT (upgrade first) 
Summary0000474: Instrument change should be delayed if used with effect 3xx (Tone Portamento)

In a ProTracker module, when using effect 3xx and changing the instrument at the same time, the instrument change should not take effect immediately. It should be remembered as the last-used instrument for the channel but the currently playing instrument should continue.

I've verified that this is the way that ProTracker v3.61 works in an emulator. MikMod v3.1.5 also agrees with this interpretation.

Steps To Reproduce

This can be seen in the u4ia mod "when i needed you" available at . At the top of pattern 12 and 13 in channel 4 is this pattern:
D-6 16v64 109
C-6 17v64 303
This should keep instrument 16 playing throughout the tone portamento and until some subsequent note is played. Changing the 17 to 16 will allow you to hear how the module is supposed to sound.

TagsNo tags attached.
Has the bug occurred in previous versions?
Tested code revision (in case you know it)


Saga Musix

Saga Musix

2014-01-13 11:15

administrator   ~0001448

Last edited: 2014-01-13 13:53

OpenMPT mostly goes after ProTracker 2.3, which is without doubt the most used ProTracker version. ProTracker 3 differs from that in various subtle and not-so-subtle ways since it tried "fixing" glitches from PT1/2, and I will keep sticking to the PT1/2 behaviour.



2014-01-14 02:46

reporter   ~0001449

Thanks for the quick response. I tried again with ProTracker 2.3d. It sounds very similar to 3.61. It seems like 2.3d switches to the new instrument once the original one hits the end and starts looping. Oddly the "Sampler" view still thinks that the original instrument is the one playing. With the speed of the song and the samples involved the difference between the 2.3d and 3.61 behaviors is hard to hear. PT 3.61 definitely waits until the next note to switch instruments. Either of these behaviors sounds better than the "switch to the new instrument immediately" behavior though.

Saga Musix

Saga Musix

2014-01-15 21:02

administrator   ~0001452

Yes, PT1/2 play the old sample until the loop point, which is often not noticeable. Anyway, I have changed this to use PT3's behaviour since this is more in line with some other trackers as well. The same fix has been applied to the S3M player, since ScreamTracker 3 does the same.
Here's a fixed version:



2014-01-17 05:06

reporter   ~0001454

Sounds good! Thanks.

Issue History

Date Modified Username Field Change
2014-01-13 05:34 abbeyj New Issue
2014-01-13 11:15 Saga Musix Note Added: 0001448
2014-01-13 11:15 Saga Musix Assigned To => Saga Musix
2014-01-13 11:15 Saga Musix Status new => feedback
2014-01-13 13:53 Saga Musix Note Edited: 0001448
2014-01-14 02:46 abbeyj Note Added: 0001449
2014-01-14 02:46 abbeyj Status feedback => assigned
2014-01-15 21:02 Saga Musix Note Added: 0001452
2014-01-15 21:02 Saga Musix Status assigned => feedback
2014-01-17 05:06 abbeyj Note Added: 0001454
2014-01-17 05:06 abbeyj Status feedback => assigned
2014-01-17 08:42 Saga Musix Status assigned => resolved
2014-01-17 08:42 Saga Musix Resolution open => fixed
2014-01-17 08:42 Saga Musix Fixed in Version => OpenMPT 1.22.07.* (old testing)
2014-01-17 08:42 Saga Musix Target Version => OpenMPT (upgrade first)
2014-01-18 17:19 Saga Musix Fixed in Version OpenMPT 1.22.07.* (old testing) => OpenMPT (upgrade first)