View Issue Details

IDProjectCategoryView StatusLast Update
0000447OpenMPTlibopenmptpublic2013-12-15 14:01
Reportermanx Assigned Tomanx  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product VersionOpenMPT 1.22.06.* (old testing) 
Target VersionOpenMPT 1.23.01.00 (upgrade first)Fixed in VersionOpenMPT 1.23.01.00 (upgrade first) 
Summary0000447: Clang 3.3 warning in tuningbase.h
Description

clang 3.3. gives the following valid warning:
[CXX] ../soundlib/tuning.cpp
In file included from ../soundlib/tuning.cpp:13:
In file included from ../soundlib/tuning.h:13:
../soundlib/tuningbase.h:306:15: warning: comparison of constant -2147483648 with expression of type 'short' is always false [-Wtautological-constant-out-of-range-compare]
if(vrp.first == STEPINDEXTYPE_MIN && vrp.second == STEPINDEXTYPE_MAX) return true;


../soundlib/tuningbase.h:306:50: warning: comparison of constant 2147483647 with expression of type 'short' is always false [-Wtautological-constant-out-of-range-compare]
        if(vrp.first == STEPINDEXTYPE_MIN && vrp.second == STEPINDEXTYPE_MAX) return true;
                                             ~~~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~
2 warnings generated.
TagsNo tags attached.
Has the bug occurred in previous versions?yes, code is unchanged since at least r192
Tested code revision (in case you know it)

Activities

manx

manx

2013-12-15 14:01

administrator   ~0001406

Fixed in r3477 .

Issue History

Date Modified Username Field Change
2013-11-16 01:16 manx New Issue
2013-11-16 01:16 manx Status new => assigned
2013-11-16 01:16 manx Assigned To => manx
2013-11-16 01:16 manx Status assigned => confirmed
2013-11-16 01:19 manx Category General => libopenmpt
2013-12-15 14:01 manx Note Added: 0001406
2013-12-15 14:01 manx Status confirmed => resolved
2013-12-15 14:01 manx Fixed in Version => OpenMPT 1.23.01.00 (upgrade first)
2013-12-15 14:01 manx Resolution open => fixed