View Issue Details

IDProjectCategoryView StatusLast Update
0000234OpenMPTFile Format Supportpublic2012-03-21 14:28
ReporterSaga Musix Assigned ToSaga Musix  
PrioritylowSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product VersionOpenMPT 1.19.04.00 (upgrade first) 
Target VersionOpenMPT 1.20.01.00 (upgrade first)Fixed in VersionOpenMPT 1.20.01.00 (upgrade first) 
Summary0000234: Unassigned sample slots are lost when saving XM files
Description

Since OpenMPT's XM saver only saves samples that can be found in some instrument's sample map, some samples can be lost when saving XM files, even though they were already present when opening an existing XM file made with Fasttracker 2.

Additional Information

Source thread: http://forum.openmpt.org/index.php?topic=4688.0

An idea to fix this would be to check the instrument assignment of any prior sample in the list when encountering an unassigned sample while saving. For example, consider this situtation: Sample 1 is assigned to instrument 1, samples 2 to 10 are not assigned to any instrument (they were originally assigned to instrument 1 in the XM file), sample 11 is assigned to instrument 2. In that case, OpenMPT could simply "guess" that samples 2 to 10 belong to instrument 1.

TagsNo tags attached.
Has the bug occurred in previous versions?
Tested code revision (in case you know it)

Activities

Saga Musix

Saga Musix

2012-03-21 14:28

administrator   ~0000670

Experimental support for this request has been added in rev. 1227.

Issue History

Date Modified Username Field Change
2012-03-10 20:25 Saga Musix New Issue
2012-03-21 01:31 Saga Musix Assigned To => Saga Musix
2012-03-21 01:31 Saga Musix Status new => assigned
2012-03-21 14:28 Saga Musix Note Added: 0000670
2012-03-21 14:28 Saga Musix Status assigned => resolved
2012-03-21 14:28 Saga Musix Resolution open => fixed
2012-03-21 14:28 Saga Musix Fixed in Version => OpenMPT 1.20.00.* (old testing)
2012-03-21 14:28 Saga Musix Target Version => OpenMPT 1.20.01.00 (upgrade first)