View Issue Details

IDProjectCategoryView StatusLast Update
0000022OpenMPTUser Interfacepublic2024-06-28 23:14
ReporterSaga Musix Assigned ToSaga Musix  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Target VersionOpenMPT 1.31.09.00 / libopenmpt 0.7.9 (upcoming stable)Fixed in VersionOpenMPT 1.31.09.00 / libopenmpt 0.7.9 (upcoming stable) 
Summary0000022: "Always center active row" vs. "Show prev/next pattern"
Description

If "Always center active row" is disabled, the "show prev/next pattern" option is ignored.

Additional Information

In theory, this could be fixed in CViewPattern::UpdateScrollSize, however "always center" doesn't work anymore if

if (CMainFrame::m_dwPatternSetup & PATTERN_CENTERROW) m_nMidRow = (rect.Height() - m_szHeader.cy) / (m_szCell.cy << 1);

is changed to

if (CMainFrame::m_dwPatternSetup & (PATTERN_CENTERROW | PATTERN_SHOWPREVIOUS)) m_nMidRow = (rect.Height() - m_szHeader.cy) / (m_szCell.cy << 1);

TagsNo tags attached.
Has the bug occurred in previous versions?Yes, all of them.
Tested code revision (in case you know it)

Activities

Saga Musix

Saga Musix

2024-06-28 23:14

administrator   ~0005986

Time to retire this old issue! Finally fixed in r21106.

Issue History

Date Modified Username Field Change
2010-11-06 12:20 Saga Musix New Issue
2010-11-06 12:21 Saga Musix Status new => confirmed
2010-11-06 12:21 Saga Musix Additional Information Updated
2024-06-28 23:14 Saga Musix Assigned To => Saga Musix
2024-06-28 23:14 Saga Musix Status confirmed => assigned
2024-06-28 23:14 Saga Musix Note Added: 0005986
2024-06-28 23:14 Saga Musix Status assigned => resolved
2024-06-28 23:14 Saga Musix Resolution open => fixed
2024-06-28 23:14 Saga Musix Fixed in Version => OpenMPT 1.31.09.00 / libopenmpt 0.7.9 (upcoming stable)
2024-06-28 23:14 Saga Musix Target Version OpenMPT 1.18.03.00 (upgrade first) => OpenMPT 1.31.09.00 / libopenmpt 0.7.9 (upcoming stable)