View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0000213OpenMPTUser Interfacepublic2011-12-02 03:282011-12-18 17:46
Reporterartscoop Assigned ToSaga Musix  
PrioritynormalSeveritymajorReproducibilityalways
Status resolvedResolutionfixed 
Platformx86OSWindowsOS VersionXP
Product VersionOpenMPT 1.19.01.00 (upgrade first) 
Target VersionOpenMPT 1.20.01.00 (upgrade first)Fixed in VersionOpenMPT 1.20.01.00 (upgrade first) 
Summary0000213: Dragging a sample to an instrument assigns the wrong sample number to the instrument
Description

I believe it started with OpenMPT 1.19, which makes it nearly unusable for me.
The problem happens when you create an instrument with an empty sample (but a VST Instrument), and then create another instrument, and drag a .wav from the left tree to the new instrument.
The new instrument will use the same sample index as the previous instrument and replace its sample, so that both instruments play the same sample (which is not a usual and desired behaviour).

Steps To Reproduce
  1. Create an IT module
  2. In the Instrument tab, create an empty instrument. It has index 1, with an empty sample at index 1.
  3. You can assign any VSTi to this instrument.
  4. Create another empty instrument. It has index 2, linked to an empty sample at index 2.
  5. Drag a .wav file from the left tree to Instrument 2.
  6. The .wav is loaded into Sample 1 instead of sample 2. Instrument 2 is now tied to sample 1. The problem is that Instrument 1 is tied to sample 1 too !
Additional Information

I think there is a bug with sample assignment when dropped onto an instrument.
The sample index for the instrument must not be changed (at least with an already used index)

TagsNo tags attached.
Has the bug occurred in previous versions?Only since 1.19 I think
Tested code revision (in case you know it)

Activities

Saga Musix

Saga Musix

2011-12-02 10:49

administrator   ~0000575

That's why you should use "Create instrument from plugin" from the plugin's GUI instead of manually assigning them (and also use MPTM for songs with plugins, not IT). But I'll look into fixing this.
Saga Musix

Saga Musix

2011-12-10 18:57

administrator   ~0000579

The behaviour has been changed so that only sample slots which are not assigned to any other instruments are now chosen when replacing an instrument. Please check if Revision 1145 / OpenMPT 1.20.00.57 works as expected: http://sagagames.de/stuff/mptrack.exe
jmkz

jmkz

2011-12-17 22:33

reporter   ~0000581

Niiice! I have tested and it's fixed for me. Thanks Jojo! ;D
artscoop

artscoop

2011-12-18 17:35

reporter   ~0000582

Yes, I confirm that the old behaviour has been restored !
Thank you saga.

Issue History

Date Modified Username Field Change
2011-12-02 03:28 artscoop New Issue
2011-12-02 10:49 Saga Musix Note Added: 0000575
2011-12-10 18:57 Saga Musix Note Added: 0000579
2011-12-10 18:57 Saga Musix Assigned To => Saga Musix
2011-12-10 18:57 Saga Musix Status new => feedback
2011-12-10 18:57 Saga Musix Target Version => OpenMPT 1.20.01.00 (upgrade first)
2011-12-17 22:33 jmkz Note Added: 0000581
2011-12-18 17:35 artscoop Note Added: 0000582
2011-12-18 17:35 artscoop Status feedback => assigned
2011-12-18 17:35 artscoop Resolution open => fixed
2011-12-18 17:46 Saga Musix Status assigned => resolved
2011-12-18 17:46 Saga Musix Fixed in Version => OpenMPT 1.20.00.* (old testing)