View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0001864 | OpenMPT | Feature Request | public | 2025-02-20 20:48 | 2025-03-29 06:41 |
Reporter | Nicu | Assigned To | |||
Priority | low | Severity | feature | Reproducibility | always |
Status | new | Resolution | open | ||
Platform | x86 / x64 | OS | Wine | OS Version | (version plz) |
Product Version | OpenMPT 1.31.14.00 / libopenmpt 0.7.13 (upgrade first) | ||||
Summary | 0001864: Scan current folder by default when external samples are missing | ||||
Description | OS: Linux Mint 21.3 Cinnamon 64-bit + wine-10.1 (Staging) A friend sent me a zip of an When I closed it, OpenMPT asked whether I wanted to save the This made me think that OpenMPT could gracefully handle missing samples like this:
The missing external samples dialog could visually mark the missing samples with a sign in front of the samples' name:
The message in the "Missing External Samples" dialog could be updated to:
The other two lines of text in the dialog can stay as they are. At the bottom of the dialog, some space could be allocated to explain the icons: ⚠️ = Sample with identical name found in current folder � = Sample not found I initially thought these would fit between the buttons, but then I considered that some translations may be longer. So making room for these two lines above the buttons seems like the better idea. P.S. Great project, by the way, and nice to meet you! :) | ||||
Tags | No tags attached. | ||||
Has the bug occurred in previous versions? | |||||
Tested code revision (in case you know it) | |||||
I think this goes against how the feature is meant to be used. The presence of those paths in the file is a feature, not a bug, and a file meant to be released publicly to other people should be prepared to not contain full paths (i.e. the author should move all samples next to the module file before saving the file - this is maybe something that could be automated with an export function in OpenMPT to make it easier) - if not for technical reasons, then at the very least for privacy reasons (random files dumped on the internet should probably not contain any references to your instrument library structure). In general I wouldn't want OpenMPT to automatically scan any folders without the user's consent - in particular because we cannot know in advance how long such a search would last, and it's possible that we would be scanning problematic files (just imagine the file is placed at the root of the C:\ drive and OpenMPT was now searching the entire Program Files and Windows folders). As a short-term solution, it might make more sense to add the module path to the "Places" list in the directory browser that shows up when clicking the "Scan Folder" button, but I'm afraid that wouldn't help you particularly because this feature is not currently present on Wine. Longer-term, the aforementioned Export option could prevent this situation from turning up in the first place. |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2025-02-20 20:48 | Nicu | New Issue | |
2025-03-13 23:05 | Saga Musix | Note Added: 0006327 |