View Issue Details

IDProjectCategoryView StatusLast Update
0001756OpenMPTlibopenmptpublic2024-03-16 09:08
ReporterDrSnuggles Assigned To 
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionno change required 
Product VersionOpenMPT 1.31.05.00 / libopenmpt 0.7.4 (upgrade first) 
Summary0001756: Emscripten _openmpt_module_get_pattern_row_channel_command always returns 0 for VOLUME and VOLUMEEFFECT
Description

I'm using the emscripten worklet version of libopenmpt and while trying to get full pattern information i found that VOLUME and VOLUMEEFFECT always return 0.

I'm calling the _openmpt_module_get_pattern_row_channel_command function in a loop.
All other calls than command = 2 or 4 return correct values.

TagsNo tags attached.
Has the bug occurred in previous versions?r20109
Tested code revision (in case you know it)r20199 r20328

Activities

manx

manx

2024-03-16 08:29

administrator   ~0005874

Are you testing with a module and in particular module format that actually has a separate volume column? For formats that do not have a separate volume column (and for modules that do not make use of it), returning 0 here is the expected behaviour.

e.g. the MOD format (example: https://modarchive.org/index.php?request=view_by_moduleid&query=42560) does not have a separate volume column, while IT or XM (example: https://modarchive.org/index.php?request=view_by_moduleid&query=55761) do.

DrSnuggles

DrSnuggles

2024-03-16 09:07

reporter   ~0005875

I'm sorry, that was my fault.
I was a bit tricked that OpenMPT shows default sample volume and expected to get those values.
I tested with non default volume values and those got correctly returned by the function call.

Thanks, and sorry again. Can be closed.

Issue History

Date Modified Username Field Change
2024-03-16 07:43 DrSnuggles New Issue
2024-03-16 08:29 manx Assigned To => manx
2024-03-16 08:29 manx Status new => feedback
2024-03-16 08:29 manx Note Added: 0005874
2024-03-16 09:07 DrSnuggles Note Added: 0005875
2024-03-16 09:07 DrSnuggles Status feedback => assigned
2024-03-16 09:08 manx Assigned To manx =>
2024-03-16 09:08 manx Status assigned => closed
2024-03-16 09:08 manx Resolution open => no change required