View Issue Details

IDProjectCategoryView StatusLast Update
0001635OpenMPTUser Interfacepublic2022-11-03 17:34
Reporterc0d3h4x0r Assigned ToSaga Musix  
PrioritynormalSeveritymajorReproducibilityalways
Status resolvedResolutionfixed 
Platformx64OSWindowsOS Version10
Product VersionOpenMPT 1.31.00.* (current testing) 
Target VersionOpenMPT 1.30.08.00 / libopenmpt 0.6.6 (current stable)Fixed in VersionOpenMPT 1.30.08.00 / libopenmpt 0.6.6 (current stable) 
Summary0001635: iOS RDP: typing into sample rate edit box double-registers each typed character
Description

The VK_PACKET fix we recently added causes double character entry, because TranslateMessage() ends up being called twice on the same WM_KEYDOWN / WM_KEYUP message, posting two copies of the corresponding WM_CHAR into the message queue.

The first TranslateMessage call is the one added by our fix. The second TranslateMessage call happens after the call stack unwinds back to the main MFC message pump/loop.

PeekMessage should probably remove the WM_CHAR message from the queue. I'll try that locally and report back.

TagsNo tags attached.
Has the bug occurred in previous versions?
Tested code revision (in case you know it)

Relationships

related to 0001634 resolvedSaga Musix Keyboard input largely (completely?) broken over Remote Desktop 

Activities

c0d3h4x0r

c0d3h4x0r

2022-11-03 06:41

reporter   ~0005362

Yep, that fixes it. I'll post a PR via GitHub (I made a few other small quality-of-life edits to the surrounding code, which you may want to take along with the fix).

c0d3h4x0r

c0d3h4x0r

2022-11-03 06:48

reporter   ~0005363

PR created: https://github.com/OpenMPT/openmpt/pull/13

Saga Musix

Saga Musix

2022-11-03 17:34

administrator   ~0005364

Thanks! Applied in r18140.

Issue History

Date Modified Username Field Change
2022-11-03 06:09 c0d3h4x0r New Issue
2022-11-03 06:38 c0d3h4x0r Relationship added related to 0001634
2022-11-03 06:41 c0d3h4x0r Note Added: 0005362
2022-11-03 06:48 c0d3h4x0r Note Added: 0005363
2022-11-03 17:34 Saga Musix Note Added: 0005364
2022-11-03 17:34 Saga Musix Assigned To => Saga Musix
2022-11-03 17:34 Saga Musix Status new => assigned
2022-11-03 17:34 Saga Musix Status assigned => resolved
2022-11-03 17:34 Saga Musix Resolution open => fixed
2022-11-03 17:34 Saga Musix Fixed in Version => OpenMPT 1.30.08.00 / libopenmpt 0.6.6 (current stable)
2022-11-03 17:34 Saga Musix Target Version => OpenMPT 1.30.08.00 / libopenmpt 0.6.6 (current stable)