View Issue Details

IDProjectCategoryView StatusLast Update
0001587OpenMPTPlayback Compatibilitypublic2024-12-21 20:44
ReporterSaga Musix Assigned ToSaga Musix  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product VersionOpenMPT 1.30.03.00 / libopenmpt 0.6.2 (upgrade first) 
Target VersionOpenMPT 1.32 / libopenmpt 0.8 (goals)Fixed in VersionOpenMPT 1.32 / libopenmpt 0.8 (goals) 
Summary0001587: Sample / OPL retrigger changes behaviour when instrument is assigned to MIDI channel
Description

Normally CSoundFile::CheckNNA is expected to end up in the forceCut path for samples and OPL instruments when being called from CSoundFile::RetrigNote. However that is not the case when a MIDI channel is assigned to the current instrument, even if there is no instrument plugin assigned.

Need to figure out what's the best way forward. Also check if there is a plugin assigned (but what if that's just an effect plugin)? Stop plugin notes in the forceCut path? That seems the most sensible and most consistent. This would in fact allow us to have an MPTM-only option to apply NNAs to retriggered notes in the future (though the way this is currently handled is a bit crude, I think, so it might require a bit more work).

TagsNo tags attached.
Has the bug occurred in previous versions?
Tested code revision (in case you know it)

Relationships

related to 0001848 resolvedSaga Musix Instrument with set MIDI channel breaks NNA on all instruments (using too many virtual channels?) 

Activities

Saga Musix

Saga Musix

2024-12-21 20:44

administrator   ~0006269

Fixed in r22601 / OpenMPT 1.32.00.38.

Issue History

Date Modified Username Field Change
2022-04-09 12:06 Saga Musix New Issue
2022-04-09 12:06 Saga Musix Status new => assigned
2022-04-09 12:06 Saga Musix Assigned To => Saga Musix
2022-04-24 15:24 Saga Musix Target Version OpenMPT 1.30.04.00 / libopenmpt 0.6.3 (upgrade first) => OpenMPT 1.30.05.00 / libopenmpt 0.6.4 (upgrade first)
2023-03-19 16:13 Saga Musix Target Version OpenMPT 1.30.05.00 / libopenmpt 0.6.4 (upgrade first) => OpenMPT 1.32 / libopenmpt 0.8 (goals)
2024-12-20 18:56 Saga Musix Relationship added related to 0001848
2024-12-21 20:44 Saga Musix Status assigned => resolved
2024-12-21 20:44 Saga Musix Resolution open => fixed
2024-12-21 20:44 Saga Musix Fixed in Version => OpenMPT 1.32 / libopenmpt 0.8 (goals)
2024-12-21 20:44 Saga Musix Note Added: 0006269