View Issue Details

IDProjectCategoryView StatusLast Update
0001575OpenMPTUser Interfacepublic2022-03-05 17:11
ReporterWodd Assigned ToSaga Musix  
PrioritynormalSeveritytweakReproducibilityalways
Status resolvedResolutionfixed 
Platformx64OSWindowsOS Version10
Product VersionOpenMPT 1.31.00.* (current testing) 
Target VersionOpenMPT 1.30.03.00 / libopenmpt 0.6.2 (upgrade first)Fixed in VersionOpenMPT 1.30.03.00 / libopenmpt 0.6.2 (upgrade first) 
Summary0001575: Go To… Dialog Upper Boundary Exceeded
Description

Someone might be able to think of a better title. However, here is the gist. For the Pattern and Order fields, the spin control stops at the final position (example: A module with 10 numerically-sorted patterns, starting at 0, will have a range of 0 to 9 for both orders and patterns and the respective spin controls do not exceed this upper boundary.) However, I have found that the row and channel spin controls will extend beyond what is present in the module (example: A module with 4 channels will show the potential for the “Channel” field of the Go To… dialog with values exceeding 4. Likewise, a pattern containing 128 rows allows for the Row spin control to exceed 127.) I thought this a bit odd.

Steps To Reproduce
  1. In any module, open the Go To… dialog.
  2. Increase the value in the channel combo box. The channel box’s range always shows 1-127. Optimally, it should show only 1-<i>highest channel number</i> (example: 5 for a module containing only 5 channels).
  3. Repeat step 2 for the row combo box. As with the channel box, it should optimally show a range of 0-<i>highest row number</i>.
Additional Information

I am excited about how far OpenMPT has come! The addition of the timestamp fields in the Go To… dialog are quite useful. These are especially useful if a person desires to use OpenMPT for practicing a song for a performance (notably when coupled with the “Maintain Sample Sync on Seek” function). The dolor-coding on the channel tabs is also nice. Something that I did find a bit odd is that the pattern editor shows slightly less information than it did before. Although, it appears to also use a different (and possibly larger) typeface. That does not affect my operations whatsoever. It was simply something that I observed.

Side note: Another thing that I thought odd is the following message in the release notes: “Fixed a possible hang when closing a module containing 65536 or more patterns.” What does that mean exactly? What defines a “pattern”? When I think of a “pattern,” I think of a group of 64 rows. However, 16 “sub-patterns” (a sequence pattern containing 1,024 rows) × 4,000 sequence patterns = 64,000 total patterns, which is less than 65,536. I figured that, based on the statement, perhaps the code allows utilizing more patterns than it did before. No dice; My current revision is set at only 65,534 (to avoid the “invalid” 65,535th position).

TagsNo tags attached.
Has the bug occurred in previous versions?
Tested code revision (in case you know it)16897

Activities

Saga Musix

Saga Musix

2022-03-05 17:01

administrator   ~0005120

Side note: Another thing that I thought odd is the following message in the release notes: “Fixed a possible hang when closing a module containing 65536 or more patterns.” What does that mean exactly? What defines a “pattern”? When I think of a “pattern,” I think of a group of 64 rows. However, 16 “sub-patterns” (a sequence pattern containing 1,024 rows) × 4,000 sequence patterns = 64,000 total patterns, which is less than 65,536. I figured that, based on the statement, perhaps the code allows utilizing more patterns than it did before. No dice; My current revision is set at only 65,534 (to avoid the “invalid” 65,535th position).

Some formats can have pattern indices higher than 4000.

Saga Musix

Saga Musix

2022-03-05 17:11

administrator   ~0005121

Fixed in r17064

Issue History

Date Modified Username Field Change
2022-03-05 16:32 Wodd New Issue
2022-03-05 17:00 Saga Musix Assigned To => Saga Musix
2022-03-05 17:00 Saga Musix Status new => assigned
2022-03-05 17:01 Saga Musix Note Added: 0005120
2022-03-05 17:11 Saga Musix Note Added: 0005121
2022-03-05 17:11 Saga Musix Status assigned => resolved
2022-03-05 17:11 Saga Musix Resolution open => fixed
2022-03-05 17:11 Saga Musix Fixed in Version => OpenMPT 1.30.03.00 / libopenmpt 0.6.2 (upgrade first)
2022-03-05 17:11 Saga Musix Target Version => OpenMPT 1.30.03.00 / libopenmpt 0.6.2 (upgrade first)