0001477: libopenmpt unused code calls into libvorbis

ID	Project	Category	View Status	Date Submitted	Last Update

0001477	OpenMPT	libopenmpt	public	2021-07-19 10:15	2022-02-16 16:51

Reporter	manx	Assigned To	manx
Priority	low	Severity	tweak	Reproducibility	sometimes
Status	closed	Resolution	no change required
Product Version	OpenMPT 1.29.12.00 / libopenmpt 0.5.11 (upgrade first)
Target Version	OpenMPT 1.31.01.00 / libopenmpt 0.7.0 (upgrade first)	Fixed in Version	OpenMPT 1.31.01.00 / libopenmpt 0.7.0 (upgrade first)

Summary	0001477: libopenmpt unused code calls into libvorbis
Description	The vorbis sample loader code uses vorbis_comment_query() from libvorbis, however this code path is never taken in libopenmpt (and removed in release builds). Even though we would still require codec.h from libvorbis (which also be transitively required by libvorbisfile), liking libvorbis could probably be eliminated from libopenmpt.
Tags	No tags attached.

Has the bug occurred in previous versions?
Tested code revision (in case you know it)

Date Modified	Username	Field	Change
2021-07-19 10:15	manx	New Issue
2021-07-19 10:15	manx	Status	new => assigned
2021-07-19 10:15	manx	Assigned To	=> manx
2022-02-16 16:51	manx	Status	assigned => closed
2022-02-16 16:51	manx	Resolution	open => no change required
2022-02-16 16:51	manx	Fixed in Version	=> OpenMPT 1.31.01.00 / libopenmpt 0.7.0 (upgrade first)
2022-02-16 16:51	manx	Note Added: 0005096

manx 2022-02-16 16:51 administrator ~0005096	This is not actually unused, but gets copied to the sample name. Even if that in turn should end up unused, it's not worth the ifdef-hastle to avoid libvorbis when libvorbisfile drags it in transitively anyway.