View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0001475OpenMPTPlayer input plugins (xmp-openmpt, in_openmpt)public2021-06-20 08:592021-06-20 09:24
ReporterJo Li KMC Assigned To 
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionduplicate 
Platformx64OSWindowsOS Version10
Product VersionOpenMPT 1.29.10.00 / libopenmpt 0.5.9 (upgrade first) 
Summary0001475: libopenmpt can't find the sample data of certain MPTM files under XMPlay
Description

The following ModPlug Tracker Module (MPTM) files refuse to play any audio in XMPlay (v3.8.5.22) using the OpenMPT (v0.5.9.15018) plugin:

OpenMPT v1.25:

  • coda - "rosemario (edit)"
  • Fearofdark - "Next"
  • goluigi - "ZILA in Space"
  • LPChip - "Internal Mechanics"
  • Saga Musix - "Shooting Star"
  • xemogasa - "verisimilitude"

OpenMPT v1.26:

  • LPChip - "Voyage home"

OpenMPT v1.27:

  • Vince Kaichan - "Visions of a Near Future"
Steps To Reproduce
  • Download and install the latest versions of XMPlay and libopenmpt
  • Install "xmp-openmpt.dll" and "openmpt-mpg123.dll" into the XMPlay plugins directory
  • Download and install/unzip any version of OpenMPT from v1.25.x onward (though preferably v1.27.x or higher)
    • [IMPORTANT] If you relocate the MPTM files, remember to move the "Samples" folder WITH them!
  • Add any of the Example Songs listed above to the XMPlay playlist and attempt to play them

Expected result: Beautiful music plays.

Actual result: Nothing but silence plays.

Additional Information

XMPlay (with the libopenmpt plugin) loads the files fine. It registers the correct play time, song title and information, and all that. For some reason I can't seem to pin down, though… it absolutely refuses to see the sample data for these specific eight songs. All of the other Example MPTM Songs that come with various versions of OpenMPT work just fine under this environment. These eight are the only ones that seem unable to find the Sample data. File location doesn't seem to matter, either.

The above Example Songs work fine under OpenMPT, itself. Just not the external player plugin.

TagsNo tags attached.
Has the bug occurred in previous versions?Unknown
Tested code revision (in case you know it)

Relationships

duplicate of 0000925 acknowledgedmanx Support for external samples in libopenmpt 

Activities

manx

manx

2021-06-20 09:13

administrator   ~0004807

Thank you very much for the very detailed bug report.

Files with external samples are not yet supported by libopenmpt. libopenmpt does issue a warning to client code, and in particular the xmp-openmpt plugin will display these warnings in the Track Info tab of XMPlay.

The reason for not supporting externals samples in libopenmpt yet is mainly due to the security implications of loading data referenced by other files, and the (up until basically about now) inconsistent availability of C++'s std::filesystem feature that would simplify implementing a security-conscious loading of such data.

This is a known issue, and other design considerations have already been discussed in 0000925. I will close this issue as a duplicate. Feel free to monitor 0000925 ("Monitor" button under the issue description) in order to get notified about progress of that issue.
manx

manx

2021-06-20 09:24

administrator   ~0004808

You can re-save those files and have the samples all included so that libopenmpt can play them properly by loading them in OpenMPT, Shift-clicking the "Keep Sample Data On Disk" option in the Samples tab (see <https://wiki.openmpt.org/Manual:_Samples#External_Samples>), and then saving.

Issue History

Date Modified Username Field Change
2021-06-20 08:59 Jo Li KMC New Issue
2021-06-20 09:13 manx Note Added: 0004807
2021-06-20 09:13 manx Relationship added duplicate of 0000925
2021-06-20 09:14 manx Status new => closed
2021-06-20 09:14 manx Resolution open => duplicate
2021-06-20 09:24 manx Note Added: 0004808