View Issue Details

IDProjectCategoryView StatusLast Update
0001464OpenMPTPlugins / VSTpublic2021-11-17 17:25
ReporterSaga Musix Assigned ToSaga Musix  
PrioritynormalSeverityminorReproducibilityhave not tried
Status resolvedResolutionfixed 
Product VersionOpenMPT 1.30.00.* (old testing) 
Target VersionOpenMPT 1.30.01.00 / libopenmpt 0.6.0 (upgrade first)Fixed in VersionOpenMPT 1.30.01.00 / libopenmpt 0.6.0 (upgrade first) 
Summary0001464: Invalid plugins now ask user twice if they want to load them natively
Description

Trying to add an invalid DLL (e.g. a VST3 DLL) as a plugin results in a series of three message boxes in the scanning process:

  • First the plugin is tried to be loaded using the regular bridge. This fails, so OpenMPT offers to load the plugin natively without the bridge.
  • Confirming that makes the plugin fail to load natively because it's still not a a VST plugin. This will of course also fail
  • Now OpenMPT tries another time to load the plugin through the legacy plugin bridge. Again it will offer to load the plugin natively instead.

The correct flow here would be:

  • Try to scan plugin using the normal bridge.
  • If that fails, silently fall back to the legacy bridge. If that works, the legacy bridge should be force-enabled for that plugin.
  • If that also fails, only then ask the user if they want to try scanning the plugin without the bridge instead.
TagsNo tags attached.
Has the bug occurred in previous versions?
Tested code revision (in case you know it)

Activities

There are no notes attached to this issue.

Issue History

Date Modified Username Field Change
2021-05-29 11:05 Saga Musix New Issue
2021-05-31 11:44 manx Status new => acknowledged
2021-11-01 13:45 Saga Musix Assigned To => Saga Musix
2021-11-01 13:45 Saga Musix Status acknowledged => assigned
2021-11-01 18:16 Saga Musix Status assigned => resolved
2021-11-01 18:16 Saga Musix Resolution open => fixed
2021-11-01 18:16 Saga Musix Fixed in Version => OpenMPT 1.30.01.00 / libopenmpt 0.6.0 (upgrade first)