View Issue Details

IDProjectCategoryView StatusLast Update
0000143OpenMPTUser Interfacepublic2014-03-29 22:11
Reporterchristofori Assigned ToSaga Musix  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Platformx86OSWindowsOS VersionXP
Product VersionOpenMPT 1.19.02.00 (upgrade first) 
Target VersionOpenMPT 1.23.01.00 (upgrade first)Fixed in VersionOpenMPT 1.23.01.00 (upgrade first) 
Summary0000143: Improper Valuetables load when entering PC or PCS events via Note Properties Dialog (NPD)
Description

When using the Note Properties dialog to enter PC or PCS events into a pattern, selecting the PC or PCS note should immediately re-load the corresponding 'Volume Command' and 'Effect Type' tables on the Volume and Effects tabs (respectively). Currently, when you select either a PC or PCS note via the dialog, the "Instrument" table is already replaced by the 'Effects' table; the same behavior should be exhibited in the Volume and Effects tabs of the Note Properties dialog (referred to as NPD from here on), as well.

Also it really seems to be only 'partly' implemented in the current version; as the effect parameters do not load into the NPD selection box(es) at all on my setup (it states, if memory serves, that they indeed DO in the OHM so it could be something specific to my install I suppose..) -- only blank values you cannot select and sliders you cannot adjust are present; regardless if you just created the PC event on a blank position by double-clicking (FE: via the NPD) or if the event already existed and you double-click it to modify via the NPD. In other words: to modify a PC or PCS I can only do so via data entry and not at all via the NPD. ;)

Steps To Reproduce

Double-click an empty space in a pattern so as to bring up the NPD; then select either a PC or PCS note, and then check the Volume and Effects tabs. Each will still be using/showing the table data which corresponds to instruments (rather than the effect parameter/value tables).

Additional Information

'table' is used in this report to mean a datatype.. likely a string array or modern day equivalent. I've not coded in aeons. ;) At any rate I think you know what I'm meaning and my appologies if anything's misleading..! Also as mentioned I use 'NPD' as short-hand for saying 'Note Properties Dialog' as (during entry) I got tired of spelling it out each time..

TagsNo tags attached.
Has the bug occurred in previous versions?Not certain, but very likely: 'Yep.'
Tested code revision (in case you know it)

Activities

Saga Musix

Saga Musix

2011-06-19 12:43

administrator   ~0000220

Well yes, PC notes don't integrate nicely with that dialog yet.

Saga Musix

Saga Musix

2014-02-09 19:42

administrator   ~0001496

This should be fixed with the redesign of the note properties dialog: http://sagagames.de/stuff/mptrack.exe

Issue History

Date Modified Username Field Change
2011-06-19 06:51 christofori New Issue
2011-06-19 07:03 christofori Summary Improper Valuetables load when entering PC or PCS events via Note Properties Dialog => Improper Valuetables load when entering PC or PCS events via Note Properties Dialog (NPD)
2011-06-19 07:03 christofori Description Updated
2011-06-19 07:03 christofori Steps to Reproduce Updated
2011-06-19 07:03 christofori Additional Information Updated
2011-06-19 07:05 christofori Description Updated
2011-06-19 12:43 Saga Musix Note Added: 0000220
2014-02-09 19:42 Saga Musix Note Added: 0001496
2014-02-09 19:42 Saga Musix Assigned To => Saga Musix
2014-02-09 19:42 Saga Musix Status new => feedback
2014-02-09 19:42 Saga Musix Target Version => OpenMPT 1.23.01.00 (upgrade first)
2014-03-29 22:11 Saga Musix Status feedback => resolved
2014-03-29 22:11 Saga Musix Resolution open => fixed
2014-03-29 22:11 Saga Musix Fixed in Version => OpenMPT 1.23.01.00 (upgrade first)