View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001409 | OpenMPT | General | public | 2021-01-20 09:24 | 2023-01-01 14:28 |
| Reporter | Saga Musix | Assigned To | |||
| Priority | normal | Severity | minor | Reproducibility | N/A |
| Status | feedback | Resolution | open | ||
| Summary | 0001409: Replace MPT_UNREFERENCED_PARAMETER and MPT_UNUSED_VARIABLE with [[maybe_unused]] | ||||
| Description | As we are on C++17 now, we can use | ||||
| Tags | No tags attached. | ||||
| Has the bug occurred in previous versions? | |||||
| Tested code revision (in case you know it) | |||||
|
I actually do not think this is useful. Quite the opposite. Around 50% of our uses are of the following form:
|
|
|
I still do not think this would be very useful. If anything, I would prefer a form of this feature that would actually warn if used in the opposite case when applied to a variable that actually does get used regardless. Our current macro does theoretically semantically allow for such a future warning, while |
|
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2021-01-20 09:24 | Saga Musix | New Issue | |
| 2021-01-20 09:34 | manx | Note Added: 0004614 | |
| 2023-01-01 14:28 | manx | Status | new => feedback |
| 2023-01-01 14:28 | manx | Note Added: 0005444 |