View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0000117OpenMPTGeneralpublic2011-04-21 23:172011-05-31 18:06
Reporter404notfound Assigned ToSaga Musix  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Platformx86OSWindowsOS Version7
Product VersionOpenMPT 1.19.01.00 (upgrade first) 
Target VersionOpenMPT 1.19.02.00 (upgrade first)Fixed in VersionOpenMPT 1.19.02.00 (upgrade first) 
Summary0000117: Incorect length in 8SVX samples
Description

The attached samples(amiga IFF I believe) and other similar ones get imported as 0 bytes long for some odd reason. Samples taken from the ST-XX.
Currently using 1.19.01.03.

Steps To Reproduce

1.Import sample.
2.Where did it go?
Temporary solution:

  1. Trim header/part of it.
  2. Import as raw sample.
TagsNo tags attached.
Attached Files
st-herpderp.zip (13,333 bytes)
Has the bug occurred in previous versions?I believe it's an old bug.
Tested code revision (in case you know it)

Activities

Saga Musix

Saga Musix

2011-04-29 21:50

administrator   ~0000176

The 8SVX headers for those samples are broken - they contain wrong size information. So OpenMPT is actually behaving correctly. "gatedbassdrum" and "techno1" claim to contain a sample that is larger than the file itself, and in "ohrfeige" the sample length is specified to be 0.
404notfound

404notfound

2011-05-02 00:28

reporter   ~0000177

Maybe have something like "Internal data size is incorrect. Open anyway?".
Saga Musix

Saga Musix

2011-05-02 10:29

administrator   ~0000178

Last edited: 2011-05-02 12:13

I can make it trim the length if there is not enough data available, but I don't really know if making a guess when the "data length" field is 0 is a good idea at all... (Reason: The specs don't say that 0 is an invalid block length, so this would break files with actual 0-byte blocks - why should we comply to broken files instead of working files?)
404notfound

404notfound

2011-05-02 13:42

reporter   ~0000179

Or offer to import as raw file if invalid.
Saga Musix

Saga Musix

2011-05-02 17:41

administrator   ~0000180

Revision 861 should treat 0 byte IFF blocks correctly.
Saga Musix

Saga Musix

2011-05-03 21:08

administrator   ~0000182

Please check if http://sagagames.de/stuff/mptrack.exe fixes the problem for you.
404notfound

404notfound

2011-05-03 22:10

reporter   ~0000184

Confirmed.
gatedbassdrum and techno1 get imported directly.
ohrfeige gets imported as raw.

Issue History

Date Modified Username Field Change
2011-04-21 23:17 404notfound New Issue
2011-04-21 23:17 404notfound File Added: st-herpderp.zip
2011-04-22 11:03 404notfound Steps to Reproduce Updated
2011-04-29 21:41 Saga Musix Summary Incorect length in amiga IFF samples => Incorect length in 8SVX samples
2011-04-29 21:50 Saga Musix Note Added: 0000176
2011-05-02 00:28 404notfound Note Added: 0000177
2011-05-02 10:29 Saga Musix Note Added: 0000178
2011-05-02 12:13 Saga Musix Note Edited: 0000178
2011-05-02 13:42 404notfound Note Added: 0000179
2011-05-02 16:49 Saga Musix Assigned To => Saga Musix
2011-05-02 16:49 Saga Musix Status new => assigned
2011-05-02 17:41 Saga Musix Note Added: 0000180
2011-05-03 21:08 Saga Musix Note Added: 0000182
2011-05-03 21:08 Saga Musix Status assigned => feedback
2011-05-03 22:10 404notfound Note Added: 0000184
2011-05-03 22:10 404notfound Status feedback => assigned
2011-05-03 22:11 Saga Musix Status assigned => resolved
2011-05-03 22:11 Saga Musix Resolution open => fixed
2011-05-03 22:11 Saga Musix Fixed in Version => OpenMPT 1.19.01.* (old testing)
2011-05-03 22:11 Saga Musix Target Version => OpenMPT 1.19.01.* (old testing)
2011-05-31 18:06 Saga Musix Target Version OpenMPT 1.19.01.* (old testing) => OpenMPT 1.19.02.00 (upgrade first)