View Issue Details

IDProjectCategoryView StatusLast Update
0000581OpenMPTlibopenmptpublic2014-09-01 16:56
Reporterwiz Assigned Tomanx  
PrioritynormalSeveritymajorReproducibilityalways
Status resolvedResolutionfixed 
Platformx86_64OSNetBSDOS Version7.99.1
Product VersionOpenMPT 1.23.04.00 / libopenmpt 0.2-beta5 (upgrade first) 
Summary0000581: libopenmpt-0.2.4115-beta5: install -D not portable
Description

install(1)'s -D option is not portable; at least FreeBSD, NetBSD, and Mac OS X do not support it.
Please create the directories separately instead of using install -D.

In my builds (with help2man, without doxygen), the following directories needed to be created manually:

bin
include/libopenmpt
lib/pkgconfig
share/man/man1 (but see bug 577)
share/doc/libopenmpt/examples

TagsNo tags attached.
Has the bug occurred in previous versions?
Tested code revision (in case you know it)

Activities

manx

manx

2014-08-27 05:13

administrator   ~0001772

Can you please check if r4218 works on NetBSD now?

manx

manx

2014-08-27 05:15

administrator   ~0001773

Also note that I'm currently working on an autotools based build system for libopenmpt (in addition to the current hand-crafted Makefile). I think this will (when finished) also solve all kinds of portability problems.

wiz

wiz

2014-08-27 10:45

reporter   ~0001774

Thank you, r4218 does indeed fix this issue.
Autotools-based build system sounds very good, thanks for working on that.

I only have two very minor issues left. Let me know if you want separate bug reports for these:

  1. the libraries are installed mode 644, some opsys need them to be 755:
    lib/libopenmpt.so.0 and lib/libopenmpt_modplug.so

  2. there is one warning during the build for me, on NetBSD-7.99.1/x86_64 with gcc 4.8.3:
    openmpt123/openmpt123.cpp:1414:25: warning: unused parameter 'log' [-Wunused-parameter]
    static commandlineflags parse_openmpt123( const std::vector<std::string> & args, std::ostream & log ) {
    ^

manx

manx

2014-09-01 16:56

administrator   ~0001782

  1. I added a INSTALL_LIB variable to the Makefile to allow setting a different mode for libraries.

  2. Warning should be gone by now.

In the future, I'd pefer separate issues in the bug tracker, even for rather trivial stuff. Makes following the bug reports and partially fixing stuff easier.

Issue History

Date Modified Username Field Change
2014-08-26 10:33 wiz New Issue
2014-08-26 12:56 manx Assigned To => manx
2014-08-26 12:56 manx Status new => assigned
2014-08-27 05:10 manx Status assigned => acknowledged
2014-08-27 05:13 manx Note Added: 0001772
2014-08-27 05:13 manx Status acknowledged => feedback
2014-08-27 05:15 manx Note Added: 0001773
2014-08-27 10:45 wiz Note Added: 0001774
2014-08-27 10:45 wiz Status feedback => assigned
2014-09-01 16:56 manx Note Added: 0001782
2014-09-01 16:56 manx Status assigned => resolved
2014-09-01 16:56 manx Resolution open => fixed