View Issue Details

IDProjectCategoryView StatusLast Update
0001737OpenMPTlibopenmptpublic2023-12-02 12:20
Reportermanx Assigned Tomanx  
PriorityhighSeverityminorReproducibilityhave not tried
Status resolvedResolutionfixed 
Product VersionOpenMPT 1.31.04.00 / libopenmpt 0.7.3 (current stable) 
Target VersionOpenMPT 1.31.05.00 / libopenmpt 0.7.4 (upcoming stable)Fixed in VersionOpenMPT 1.31.05.00 / libopenmpt 0.7.4 (upcoming stable) 
Summary0001737: make CONFIG=emscripten EMSCRIPTEN_TARGET=wasm check produces no output
Description

make CONFIG=emscripten EMSCRIPTEN_TARGET=wasm check produces no output

TagsNo tags attached.
Has the bug occurred in previous versions?
Tested code revision (in case you know it)

Activities

manx

manx

2023-12-02 09:06

administrator   ~0005809

This broke between r19468 (good) and r19471 (bad) in 0.7.

manx

manx

2023-12-02 09:11

administrator   ~0005810

The breaking change is r19470:

Merged revision(s) 19469 from trunk/OpenMPT:
[Fix] build: Makefile: Emscripten: Emscripten 3.1.31 stopped exporting malloc and free by default (see <https://github.com/emscripten-core/emscripten/pull/18564>). As memory needs to get transferred to and from libopenmpt in all use cases, these really should get exported. Revert Emscripten change by exporting these function manually. Fixes <https://github.com/OpenMPT/openmpt/pull/16>.
Patch-by: Essem <smswessem@gmail.com>
........

See <https://github.com/OpenMPT/openmpt/pull/16> and <https://github.com/emscripten-core/emscripten/pull/18564>.

manx

manx

2023-12-02 12:20

administrator   ~0005811

Fixed in r19957.

Issue History

Date Modified Username Field Change
2023-11-30 13:11 manx New Issue
2023-11-30 13:11 manx Status new => assigned
2023-11-30 13:11 manx Assigned To => manx
2023-11-30 13:11 manx Priority normal => high
2023-12-02 09:06 manx Note Added: 0005809
2023-12-02 09:11 manx Note Added: 0005810
2023-12-02 12:20 manx Note Added: 0005811
2023-12-02 12:20 manx Product Version OpenMPT 1.32.00.* (current testing) => OpenMPT 1.31.04.00 / libopenmpt 0.7.3 (current stable)
2023-12-02 12:20 manx Fixed in Version => OpenMPT 1.31.05.00 / libopenmpt 0.7.4 (upcoming stable)
2023-12-02 12:20 manx Status assigned => resolved
2023-12-02 12:20 manx Resolution open => fixed