View Issue Details

IDProjectCategoryView StatusLast Update
0000758OpenMPT[All Projects] File Format Supportpublic2016-03-18 18:50
Reporterchris82Assigned ToSaga Musix 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product VersionOpenMPT 1.25.04.00 / libopenmpt 0.2-beta16 (upgrade first) 
Target VersionOpenMPT 1.26.01.00 / libopenmpt 0.2-beta17 (upgrade first)Fixed in VersionOpenMPT 1.26.01.00 / libopenmpt 0.2-beta17 (upgrade first) 
Summary0000758: Soundfonts sf2 doesn't import sample names, but revert to program name
Description

Currently when importing sf2 it doesn't set the name.
I attach the fix.

TagsNo tags attached.
Has the bug occurred in previous versions?
Tested code revision (in case you know it)

Activities

chris82

chris82

2016-03-18 17:39

reporter  

Dlsbank.zip (13,995 bytes)
Saga Musix

Saga Musix

2016-03-18 18:34

administrator   ~0002293

Thanks for the fix. In the future, please provide your fixes as .patch files so that it's clear what has changed. Your cpp file is from an earlier version of the code so it includes line changes that shouldn't be there.

Saga Musix

Saga Musix

2016-03-18 18:50

administrator   ~0002294

Fixed in r6141. I had to modify your fix though, as it would no longer have imported the instrument name for DLS files (the line you removed was for both DLS and SF2, but the fix you added was in a block that is only processed for SF2 files).

Issue History

Date Modified Username Field Change
2016-03-18 17:39 chris82 New Issue
2016-03-18 17:39 chris82 File Added: Dlsbank.zip
2016-03-18 18:34 Saga Musix Note Added: 0002293
2016-03-18 18:34 Saga Musix Assigned To => Saga Musix
2016-03-18 18:34 Saga Musix Status new => assigned
2016-03-18 18:50 Saga Musix Note Added: 0002294
2016-03-18 18:50 Saga Musix Status assigned => resolved
2016-03-18 18:50 Saga Musix Resolution open => fixed
2016-03-18 18:50 Saga Musix Fixed in Version => OpenMPT 1.26.01.00 / libopenmpt 0.2-beta17 (upgrade first)
2016-03-18 18:50 Saga Musix Target Version => OpenMPT 1.26.01.00 / libopenmpt 0.2-beta17 (upgrade first)