View Issue Details

IDProjectCategoryView StatusLast Update
0000337OpenMPTFeature Requestpublic2015-11-17 16:57
ReporterDiamond Assigned ToSaga Musix  
PrioritynormalSeverityminorReproducibilityN/A
Status resolvedResolutionfixed 
Platformx86OSWindowsOS Version7
Product VersionOpenMPT 1.21.01.* (old testing) 
Target VersionOpenMPT 1.25.04.00 / libopenmpt 0.2-beta16 (upgrade first)Fixed in VersionOpenMPT 1.25.04.00 / libopenmpt 0.2-beta16 (upgrade first) 
Summary0000337: Accessibility - Control for VST gain in general tab
Description

I have what is sort of a feature request, but is more of a request for a minor improvement to accessibility. In the "General" tab, you can cycle through most of the controls using the Tab and Shift+Tab keys. The VST gain selector however does not have a control associated with it in the tab order so it cannot be adjusted from the keyboard. Or if there is an existing control, it is not in the keyboard tab order. Basically my request is that a control of some kind be associated with the VST gain and put in the tab order so that it can be adjusted using the keyboard. Maybe a slider or edit field might make the most sense.

TagsNo tags attached.
Has the bug occurred in previous versions?
Tested code revision (in case you know it)

Activities

Saga Musix

Saga Musix

2013-01-20 13:35

administrator   ~0001056

Right, the tabstop property is missing from this control. However, even when enabling tabstop, it doesn't seem to accept cursor keys to change the value...

Diamond

Diamond

2013-01-20 13:47

reporter   ~0001057

I don't know if this is the case, but I believe that problem may sometimes occur if it is not a standard control. Maybe change the control type?

Saga Musix

Saga Musix

2013-01-20 13:51

administrator   ~0001058

It's a standard spin control, it's just not bound to an edit box like most other spinners in OpenMPT. It doesn't really make sense to change it to a different kind of control, but it could possibly be attached to an edit box.

Diamond

Diamond

2013-01-20 13:54

reporter   ~0001059

That should be fine.

Diamond

Diamond

2015-11-13 03:15

reporter   ~0002178

Is there any progress on improving keyboard access to this control? I see that a spin control was added so it is now in the tab order, but the value still cannot be changed using the keyboard. I'm asking now because previously I was at least able to click the scroll up/down arrows using the mouse functionality of my screen reader to change the value, but while I'm not sure in what version, some recent change has made it impossible for me to find that area using said mouse functionality.

Saga Musix

Saga Musix

2015-11-13 12:49

administrator   ~0002181

The spin control has not been modified and I still don't know why your screen reader won't find the spin button.

Diamond

Diamond

2015-11-13 13:11

reporter   ~0002183

Sorry, I should have said that it seems that the tabstop property was added since I can now move focus to the control using Tab/Shift Tab keyboard navigation, but it's value still cannot be modified using the keyboard. In other words, my screen reader does see the control now if I am just cycling using Tab or Shift+Tab. I can no longer find the scroll arrows for the control just using mouse navigation functionality of my screen reader, but that is a separate issue. I only mention this because it was the only way I was able to modify it's value in the past. If I could modify it's value using the keyboard as I can with other spin controls in OpenMPT, then not being able to find it using mouse functionality would be irrelevant.

Saga Musix

Saga Musix

2015-11-13 13:12

administrator   ~0002184

I'll see if I can replace the gain control now that we have decimal input fields with input validation anyway.

Saga Musix

Saga Musix

2015-11-17 01:39

administrator   ~0002187

Can you check if this version works better for you? http://sagagames.de/stuff/mptrack.exe

Diamond

Diamond

2015-11-17 02:22

reporter   ~0002188

Well, it works better in that I can now read the value, but unless I'm missing something, it is still not possible to change the value by either typing it in or with the arrow keys.

Saga Musix

Saga Musix

2015-11-17 02:27

administrator   ~0002189

I'll see how I can get cursor keys to work. The control remains locked for editing since it only accepts a very small range of values.

Saga Musix

Saga Musix

2015-11-17 16:13

administrator   ~0002190

I made some modifications but I don't think they work; can you redownload and check? If that does indeed not work for you, there's one way left to fix it which would require some things to be changed around.

Diamond

Diamond

2015-11-17 16:42

reporter   ~0002191

Seems about the same as far as I can tell. Thanks for the effort.

Saga Musix

Saga Musix

2015-11-17 16:49

administrator   ~0002192

Ok, last resort then. Please redownload.

Diamond

Diamond

2015-11-17 16:56

reporter   ~0002193

Yep that works with the up/down arrow keys. Thanks.

Issue History

Date Modified Username Field Change
2013-01-20 09:17 Diamond New Issue
2013-01-20 13:35 Saga Musix Note Added: 0001056
2013-01-20 13:47 Diamond Note Added: 0001057
2013-01-20 13:51 Saga Musix Note Added: 0001058
2013-01-20 13:54 Diamond Note Added: 0001059
2015-11-13 03:15 Diamond Note Added: 0002178
2015-11-13 12:49 Saga Musix Note Added: 0002181
2015-11-13 13:11 Diamond Note Added: 0002183
2015-11-13 13:12 Saga Musix Note Added: 0002184
2015-11-17 01:39 Saga Musix Note Added: 0002187
2015-11-17 02:22 Diamond Note Added: 0002188
2015-11-17 02:27 Saga Musix Note Added: 0002189
2015-11-17 16:13 Saga Musix Note Added: 0002190
2015-11-17 16:42 Diamond Note Added: 0002191
2015-11-17 16:49 Saga Musix Note Added: 0002192
2015-11-17 16:56 Diamond Note Added: 0002193
2015-11-17 16:57 Saga Musix Assigned To => Saga Musix
2015-11-17 16:57 Saga Musix Status new => assigned
2015-11-17 16:57 Saga Musix Status assigned => resolved
2015-11-17 16:57 Saga Musix Resolution open => fixed
2015-11-17 16:57 Saga Musix Fixed in Version => OpenMPT 1.25.04.00 / libopenmpt 0.2-beta16 (upgrade first)
2015-11-17 16:57 Saga Musix Target Version => OpenMPT 1.25.04.00 / libopenmpt 0.2-beta16 (upgrade first)