View Issue Details

IDProjectCategoryView StatusLast Update
0000958OpenMPT[All Projects] Generalpublic2017-07-02 15:50
ReporterYarn366Assigned ToSaga Musix 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Platformx64OSWindowsOS Version7
Product VersionOpenMPT 1.27.00.* (old testing) 
Target VersionOpenMPT 1.26.12.00 / libopenmpt 0.2-beta26 (upgrade first)Fixed in VersionOpenMPT 1.26.12.00 / libopenmpt 0.2-beta26 (upgrade first) 
Summary0000958: 64-pattern MODs saved with M!K! magic instead of M.K.
Description

This is most likely caused by an off-by-one error in the MOD writer, where M.K. is chosen if there are less than 64 patterns. It should be less than or equal to 64.

Also, in the MOD loader, the comment for the M!K! magic reads "ProTracker (64+ patterns)". That should read something like ">64 patterns".

TagsNo tags attached.
Has the bug occurred in previous versions?Yes
Tested code revision (in case you know it)r8211

Activities

Saga Musix

Saga Musix

2017-05-25 08:09

administrator   ~0003035

r8213 fixes this. Thanks!

Issue History

Date Modified Username Field Change
2017-05-25 05:01 Yarn366 New Issue
2017-05-25 08:02 Saga Musix Assigned To => Saga Musix
2017-05-25 08:02 Saga Musix Status new => assigned
2017-05-25 08:09 Saga Musix Note Added: 0003035
2017-05-25 08:09 Saga Musix Status assigned => resolved
2017-05-25 08:09 Saga Musix Resolution open => fixed
2017-05-25 08:09 Saga Musix Fixed in Version => OpenMPT 1.27.01.00 / libopenmpt 0.3.1 (upgrade first)
2017-05-25 08:09 Saga Musix Target Version => OpenMPT 1.27.01.00 / libopenmpt 0.3.1 (upgrade first)
2017-07-02 15:50 Saga Musix Fixed in Version OpenMPT 1.27.01.00 / libopenmpt 0.3.1 (upgrade first) => OpenMPT 1.26.12.00 / libopenmpt 0.2-beta26 (upgrade first)
2017-07-02 15:50 Saga Musix Target Version OpenMPT 1.27.01.00 / libopenmpt 0.3.1 (upgrade first) => OpenMPT 1.26.12.00 / libopenmpt 0.2-beta26 (upgrade first)