View Issue Details

IDProjectCategoryView StatusLast Update
0000910OpenMPT[All Projects] Generalpublic2017-01-14 22:05
ReporterWodd 
Assigned To 
PrioritynormalSeveritycrashReproducibilitysometimes
Status newResolutionopen 
Platformx64OSWindowsOS Version10
Product Version 
Target VersionFixed in Version 
Summary0000910: Sometimes Crashes When Loading Samples
Description

I have noticed that OpenMPT sometimes crashes when attempting to load samples.

Additional Information

I have attached the crash dump for you. I hope that it is useful.

TagsNo tags attached.
Has the bug occurred in previous versions?
Tested code revision (in case you know it)

Relationships

Activities

Wodd

Wodd

2017-01-11 03:23

reporter  

crash.zip (23,637 bytes)
Saga Musix

Saga Musix

2017-01-11 13:29

administrator   ~0002834

As always, I need to know the exact code revision you used, and in case you compiled it yourself, the mptrack.exe/mptrack.pdb files; and preferrably also the sample the problem happened with.

Wodd

Wodd

2017-01-12 06:06

reporter   ~0002836

I need to know the exact code revision you used

revision 7469

the mptrack.exe/mptrack.pdb files

https://drive.google.com/open?id=0BwzzNTe3LlQlNWZjZHR4cGNoS0E
There were 2 files that I was working with during the most recent crash. I don't remember, however, which of them OpenMPT was attempting to load when the crash occurred. That is why I included both of them.
Because the issue is intermittent, it might take several tries to produce (if you do). Depending on the cause, updating my revision might solve the issue. I do very much dislike intermittent behaviors like this for this reason. Trying to describe them to developers or even reproduce them or give steps to reproduce them to developers is challenging (at best). There is a file named error.txt in the crash folder. It contains the following line. It might be useful. Unhandled exception 0xC0000005 at address 00007FFA64F3C855 occurred. But, I don't see mention of the file within the code in which the exception occurred. Given that case, that line might not be of any use (or of little use) to you.

Saga Musix

Saga Musix

2017-01-12 13:25

administrator   ~0002837

Last edited: 2017-01-12 13:40

View 2 revisions

The crash seems to happen in the file dialog (on Windows' side, not ours) with a null pointer, which might imply an out-of-memory situation. Do you have "Preview samples / instruments in file browser" enabled?Does it happen with samples of any size (especially smaller ones)? Does it also happen if you drag-and-drop the samples into the sample editor rather than loading them through the file dialog?

Saga Musix

Saga Musix

2017-01-12 13:30

administrator   ~0002838

Last edited: 2017-01-12 13:30

View 2 revisions

Crash signature seems to be identical to this Mozilla report: https://bugzilla.mozilla.org/show_bug.cgi?id=1324180

Wodd

Wodd

2017-01-13 01:57

reporter   ~0002841

Do you have "Preview samples / instruments in file browser" enabled?

I am guessing that you are referring to the preview pane. Yes, I do have that enabled.

Does it happen with samples of any size (especially smaller ones)?

I am not sure. It might happen with those. I looked through some other crashes. But, I didn't see any clues as to what samples might have caused the crashes.

Does it also happen if you drag-and-drop the samples into the sample editor rather than loading them through the file dialog?

I have not tried that. Because I have OpenMPT's window restored up / maximized (I am not sure exactly what the difference is between "Maximize" and "restore up." I know that the common term used is "maximize." But, I also happen to know that they are differentiated within Windows' sound scheme.) and Windows Explorer's window restored down / minimized, that should not be a big deal to get used to doing that (at least, until such a time as the bug that causes the crash is fixed).

Crash signature seems to be identical to this Mozilla report: https://bugzilla.mozilla.org/show_bug.cgi?id=1324180

It is nice to see that the issue is unrelated to your code. It probably still doesn't hurt to update my revision, though.

Saga Musix

Saga Musix

2017-01-13 12:38

administrator   ~0002842

I am guessing that you are referring to the preview pane. Yes, I do have that enabled.

No, I am referring to the option with this exact name found in the options dialog. I do not know what the "Preview Pane" is supposed to be.

I am not sure.

Then do find it out.

I have not tried that.

I didn't want to hear an explanation why you didn't do it like that in the past, I want you to try it now to confirm if the problem does not happen that way.

Wodd

Wodd

2017-01-14 03:17

reporter   ~0002845

Does it also happen if you drag-and-drop the samples into the sample editor rather than loading them through the file dialog?

I have tested that and did not see any crashes.

No, I am referring to the option with this exact name found in the options dialog.

I looked at the advanced settings and found an option named PreviewInFileDialogs under a heading named Sample Editor. It is disabled.

Does it happen with samples of any size (especially smaller ones)?

I tested 23 samples (of varying sizes) and detected no crashes. I am also using revision 7518 now.

Saga Musix

Saga Musix

2017-01-14 13:22

administrator   ~0002846

What is this "Preview Pane" then? Is that a Windows option to preview files? If so, disable that to see if it makes a difference.

Wodd

Wodd

2017-01-14 22:05

reporter   ~0002848

Is that a Windows option to preview files?

Yes. It is handy for looking at pictures.

disable that to see if it makes a difference.

It might. I reproduced the problem twice. But, in an attempt to reproduce it a third time, I was unsuccessful. That is why there are no reproduction steps provided. I started making the list; but, I stopped because I was unable to reproduce the problem again. But, it involved these samples: https://drive.google.com/open?id=0BwzzNTe3LlQldGNtcUxzSUtkREU
Incidentally, the crash occurred while OpenMPT attempted to load the larger file (01 Track 1) in both cases. It did not crash while loading Windows Balloon.

Issue History

Date Modified Username Field Change
2017-01-11 03:23 Wodd New Issue
2017-01-11 03:23 Wodd File Added: crash.zip
2017-01-11 13:29 Saga Musix Note Added: 0002834
2017-01-12 06:06 Wodd Note Added: 0002836
2017-01-12 13:25 Saga Musix Note Added: 0002837
2017-01-12 13:30 Saga Musix Note Added: 0002838
2017-01-12 13:30 Saga Musix Note Edited: 0002838 View Revisions
2017-01-12 13:40 Saga Musix Note Edited: 0002837 View Revisions
2017-01-13 01:57 Wodd Note Added: 0002841
2017-01-13 12:38 Saga Musix Note Added: 0002842
2017-01-14 03:17 Wodd Note Added: 0002845
2017-01-14 13:22 Saga Musix Note Added: 0002846
2017-01-14 22:05 Wodd Note Added: 0002848