View Issue Details

IDProjectCategoryView StatusLast Update
0000797OpenMPT[All Projects] User Interfacepublic2016-05-18 16:14
ReporterWoddAssigned ToSaga Musix 
PrioritynormalSeveritytweakReproducibilityalways
Status resolvedResolutionfixed 
Platformx64OSWindowsOS Version10
Product VersionOpenMPT 1.26.00.* (old testing) 
Target VersionOpenMPT 1.26.01.00 / libopenmpt 0.2-beta17 (upgrade first)Fixed in VersionOpenMPT 1.26.01.00 / libopenmpt 0.2-beta17 (upgrade first) 
Summary0000797: Possibly Backwards
Description

I noticed that an attempt was made to update the passion jump to accommodate the parameter extension ( http://bugs.openmpt.org/view.php?id=789 ). However, it seems backwards. The position jump effect shows 0 to 255 while the parameter extension shows 0 to 65,535. In an attempt to jump beyond position 255, it didn't happen, even with the parameter extension set further.

Steps To Reproduce
  1. Create a new module with a to least 257 patterns.
  2. Place a position jump and a parameter extension in a pattern.
  3. Set the position jump to 1.
  4. Check position jump.
    At this point, the position jump should still show values between 0 and 255.
  5. Check parameter extension.
    At this point, the parameter extension should show values between 256 and 511.
    Play the pattern. The module should jump to pattern 255, not 256 (assuming that your patterns are 0-256 with no gaps).
Additional Information

Thank you for adding this feature. But, it seems to need a minor tweak.

TagsNo tags attached.
Has the bug occurred in previous versions?
Tested code revision (in case you know it)6373

Activities

Saga Musix

Saga Musix

2016-05-18 14:06

administrator   ~0002396

The command is used like all other X-Param commands:

ModPlug Tracker MPT
|........B01
|........#..

This example will jump to order 256 (1 * 256 + 0), so there is nothing broken.
The display in the status bar cannot be fixed for now, but I noticed that the display in the Note Properties was a bit off, so that is fixed now.

Saga Musix

Saga Musix

2016-05-18 16:14

administrator   ~0002402

After some modifications, the status bar can now also display the correct X-Param value.

Issue History

Date Modified Username Field Change
2016-05-18 13:41 Wodd New Issue
2016-05-18 14:06 Saga Musix Note Added: 0002396
2016-05-18 14:06 Saga Musix Assigned To => Saga Musix
2016-05-18 14:06 Saga Musix Status new => resolved
2016-05-18 14:06 Saga Musix Resolution open => fixed
2016-05-18 14:06 Saga Musix Fixed in Version => OpenMPT 1.26.01.00 / libopenmpt 0.2-beta17 (upgrade first)
2016-05-18 14:06 Saga Musix Target Version => OpenMPT 1.26.01.00 / libopenmpt 0.2-beta17 (upgrade first)
2016-05-18 16:14 Saga Musix Note Added: 0002402