View Issue Details

IDProjectCategoryView StatusLast Update
0001119OpenMPT[All Projects] User Interfacepublic2018-05-08 22:07
ReporterWoddAssigned ToSaga Musix 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Platformx64OSWindowsOS Version10
Product VersionOpenMPT 1.28.00.* (current testing) 
Target VersionOpenMPT 1.28.01.00 (goals)Fixed in VersionOpenMPT 1.28.01.00 (goals) 
Summary0001119: Unexpected Behaviors With Go To Dialog
Description

I updated my subversion to revision 10204 and am seeing some unexpected behaviors.

  1. When I open the Go to… dialog (which I see has been revamped to include spin controls instead of standard text boxes), I see the following message twice before it opens. Attempted an unsupported operation. When I press Control-G or use the Goto option from the Edit menu, I see that message appear. When the OK button is activated, it appears again. When the OK button is activated in the second dialog, the Go to… dialog opens.
  2. The pattern and order fields behave incorrectly.
    a. Upon activating the up arrow in the spin control when its value is 999 results in the value changing to 1 rather than 1,000.
    b. Changing the row quantity to 1,000 or greater does the behavior mentioned in the previous item also after activating the spin control in the Pattern or Order field.
  3. After going to the desired location, the play cursor navigates to the end of the row.
  4. The initial channel value is 0, not 1.
Steps To Reproduce
  1. Activate the Goto option via keyboard or the Edit menu.
  2. Activate the OK button on each dialog that appears.
  3. In the Pattern or Order field, type 999.
  4. Activate the up arrow in the spin control for the respective field. You should see the value change to 1 rather than 1,000.
  5. In the Row field, type 999.
  6. Activate the up arrow on its spin control. You should see the value 1,000.
  7. Repeat steps 3 and 4. You should see the row value change to 1 rather than stay 1,000. The value being 1 is validated by activating the row field's spin control again. The value increases to 2 rather than 1,001.
  8. Activate the OK button in the Go to… dialog. You should notice that OpenMPT has navigated to the desired locations. But, it has also navigated to the end of the row.
TagsNo tags attached.
Has the bug occurred in previous versions?Not that I know of
Tested code revision (in case you know it)10204

Activities

Saga Musix

Saga Musix

2018-05-08 21:44

administrator   ~0003524

It really isn't necessary to write a 20-line bug report when it can be summarized in a single sentence ("The Goto dialog is broken and non-functional.").

Anyway, I guess it's time to really say goodbye to DataExchange + UpdateData here, it has caused more trouble in this dialog than doing good. The code should be refactored to work like all our other dialog code to prevent these kind of errors in the future,

Saga Musix

Saga Musix

2018-05-08 22:07

administrator   ~0003525

Fixed in r10207.

Issue History

Date Modified Username Field Change
2018-05-08 20:50 Wodd New Issue
2018-05-08 20:56 Saga Musix Assigned To => Saga Musix
2018-05-08 20:56 Saga Musix Status new => assigned
2018-05-08 21:44 Saga Musix Note Added: 0003524
2018-05-08 22:07 Saga Musix Status assigned => resolved
2018-05-08 22:07 Saga Musix Resolution open => fixed
2018-05-08 22:07 Saga Musix Fixed in Version => OpenMPT 1.28.01.00 (goals)
2018-05-08 22:07 Saga Musix Target Version => OpenMPT 1.28.01.00 (goals)
2018-05-08 22:07 Saga Musix Note Added: 0003525